Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added p2p.org as Staking as a Service Provider to the website #11281

Merged
merged 6 commits into from
Oct 30, 2023

Conversation

rgb2hsl
Copy link
Contributor

@rgb2hsl rgb2hsl commented Sep 27, 2023

  1. Added P2P.org icon
  2. P2P.org added to staking services as SaaS

Related Issue

#11279

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 27, 2023

✅ ethereum-org-website-dev deploy preview ready

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgb2hsl Hey! Thanks for the PR here... just gave it a review and things are overall looking good...
I left a couple change requests for ya, and if you're okay with these I think we can pull this in!

src/data/staking-products.json Outdated Show resolved Hide resolved
src/data/staking-products.json Outdated Show resolved Hide resolved
src/components/icons/staking/P2PGlyphIcon.tsx Outdated Show resolved Hide resolved
src/components/icons/staking/P2PGlyphIcon.tsx Outdated Show resolved Hide resolved
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for ethereumorg ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 60e25f6
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/653a2aec90caf60008907702
😎 Deploy Preview https://deploy-preview-11281--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rgb2hsl and others added 3 commits October 25, 2023 16:33
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@rgb2hsl
Copy link
Contributor Author

rgb2hsl commented Oct 26, 2023

@wackerow hey, I've accepted all the changes you've suggested. Let's move this on :)

@rgb2hsl rgb2hsl requested a review from wackerow October 26, 2023 09:02
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @rgb2hsl!

@wackerow wackerow merged commit 9c497ec into ethereum:dev Oct 30, 2023
5 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 30, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2023 Ethereum.org Contributor:

GitPOAP: 2023 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @rgb2hsl for content

@allcontributors
Copy link
Contributor

@wackerow

I've put up a pull request to add @rgb2hsl! 🎉

@rgb2hsl rgb2hsl deleted the 11279-add-p2p-saas branch October 31, 2023 08:41
This was referenced Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants