Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added banner on community page #11319

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

rohan9024
Copy link
Contributor

@rohan9024 rohan9024 commented Sep 30, 2023

Fixes #11316

Referenced this previous PR- #10078

The banner is displayed on community page

Screenshots-

image

image

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies review needed 👀 labels Sep 30, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 30, 2023

✅ ethereum-org-website-dev deploy preview ready

@corwintines
Copy link
Member

@rohan9024 I wanted to review this, but I see there are a lot of commits from #11075 in this PR.

Looking at your nav PR above, I see that was from your dev branch, so when you made this branch it included all those commits. If you can, those commits should be removed from this PR. If you don't have time today that is totally understandable, I will make a new PR with this if so for this release.

@rohan9024
Copy link
Contributor Author

@rohan9024 I wanted to review this, but I see there are a lot of commits from #11075 in this PR.

Looking at your nav PR above, I see that was from your dev branch, so when you made this branch it included all those commits. If you can, those commits should be removed from this PR. If you don't have time today that is totally understandable, I will make a new PR with this if so for this release.

I wanted to ask whether the changes I have done in this PR is right? Then I can merge it with my dev branch.

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rohan9024

I just updated this to also show on the homepage.

@corwintines corwintines merged commit 4924716 into ethereum:dev Oct 3, 2023
3 of 4 checks passed
@rohan9024 rohan9024 deleted the addingBanner branch October 4, 2023 02:39
This was referenced Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add banner: Ethereum.org Writers Cohort (2nd edition)
2 participants