-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Examples Returning Non-Trivial Response #11320
Conversation
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bh2smith!
Makes sense to me, @jmcook1186 what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm this looks good, just going to update the curl
example with the same and pull this in, and also update on non-English pages. Good catch, thanks @bh2smith
@@ -1245,8 +1245,8 @@ Returns information about a transaction by block number and transaction index po | |||
|
|||
```js | |||
params: [ | |||
"0x29c", // 668 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol 😆 That's really funny that this example had no transactions... rugged!
@all-contributors please add @bh2smith for bug fix |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
I've put up a pull request to add @bh2smith! 🎉 |
I was testing out these endpoints and found it confusing that the example values return unexpected response:
Turns out that block
668
contains no transactions: cf https://etherscan.io/block/668So I picked an example transaction that actually exists. It is the transaction with the highest total fee paid (10_668 ETH) -- cf Dune Analytics.
Test Plan
Observe that:
returns