Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme/Heading): flip lineHeights rendered to match DS #11363

Merged

Conversation

TylerAPfledderer
Copy link
Contributor

Description

This PR addresses the lineHeights not being applied correctly for the Heading component. Based on breakpoint, the sizes either needed to be flipped or replaced to match the DS

Related Issue

N/A

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 4, 2023

✅ ethereum-org-website-dev deploy preview ready

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pettinarip pettinarip merged commit 379c440 into ethereum:dev Oct 18, 2023
4 checks passed
@TylerAPfledderer TylerAPfledderer deleted the fix/heading-flip-line-heights branch October 18, 2023 13:36
This was referenced Oct 25, 2023
This was referenced Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants