Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chinese traditional (zh-tw) translated images for buckets 7 and 11 #11456

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Add Chinese traditional (zh-tw) translated images for buckets 7 and 11 #11456

merged 5 commits into from
Nov 1, 2023

Conversation

nloureiro
Copy link
Contributor

Add the translation images for:

Zh-TW: bucket 7, bucket 11

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Oct 17, 2023
minimalsm
minimalsm requested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nloureiro I'd expected us to have have fixed alignment on a few of these images.

Screenshot 2023-10-17 at 11 56 54 Screenshot 2023-10-17 at 11 57 34

@minimalsm minimalsm changed the title Translated images Add Chinese traditional (zh-tw) translated images for buckets 7 and 11 Oct 17, 2023
minimalsm
minimalsm requested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the web1 image as it's identical to the fallback version

@nloureiro
Copy link
Contributor Author

@nloureiro I'd expected us to have have fixed alignment on a few of these images.

Screenshot 2023-10-17 at 11 56 54 Screenshot 2023-10-17 at 11 57 34

yes, still testing the flow

will fix this for sure

@nloureiro
Copy link
Contributor Author

We should remove the web1 image as it's identical to the fallback version

ok

@minimalsm
Copy link
Contributor

Ahh I see, if you're just testing out flow be sure to mark as draft until ready for review :)

@nloureiro nloureiro self-assigned this Oct 17, 2023
@nloureiro nloureiro changed the title Add Chinese traditional (zh-tw) translated images for buckets 7 and 11 [not merge yet - testing the flow]Add Chinese traditional (zh-tw) translated images for buckets 7 and 11 Oct 17, 2023
@nloureiro nloureiro changed the title [not merge yet - testing the flow]Add Chinese traditional (zh-tw) translated images for buckets 7 and 11 Add Chinese traditional (zh-tw) translated images for buckets 7 and 11 Oct 17, 2023
@nloureiro
Copy link
Contributor Author

ready for review

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 17, 2023 •
edited
Loading

✅ ethereum-org-website-dev deploy preview ready

@corwintines corwintines merged commit b4c9b18 into dev Nov 1, 2023
3 checks passed
@corwintines corwintines deleted the translated-images branch November 1, 2023 13:52
@corwintines corwintines mentioned this pull request Nov 1, 2023
Merged
@corwintines corwintines mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm requested changes

@corwintines corwintines corwintines approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

@nhsz nhsz Awaiting requested review from nhsz

Assignees

@nloureiro nloureiro

Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nloureiro @minimalsm @corwintines