Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trust Wallet #11566

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Add Trust Wallet #11566

merged 8 commits into from
Mar 26, 2024

Conversation

corwintines
Copy link
Member

Description

  • Add Trust Wallet logo
  • Add Trust Wallet data

Related Issue

Fixes #10692

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 7dad7a6
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6601d86749a74200082643b0
😎 Deploy Preview https://deploy-preview-11566--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wackerow
Copy link
Member

wackerow commented Mar 7, 2024

@corwintines Are we waiting on anything here? @nhsz Any issues you foresee with this and #12299?

@nhsz
Copy link
Member

nhsz commented Mar 7, 2024

@corwintines Are we waiting on anything here? @nhsz Any issues you foresee with this and #12299?

@corwintines @wackerow thinking again, as we're doing some changes to the wallets metadata in #12299 (eg: some props are being removed), it would be better to wait until that PR is merged, make the necessary changes here and merge it later to avoid conflicts now

@wackerow
Copy link
Member

Ok, #12299 has been merged... this should be ready to be updated before merging in

@wackerow wackerow merged commit 149dc97 into dev Mar 26, 2024
6 checks passed
@wackerow wackerow deleted the addTrustWallet branch March 26, 2024 01:14
@Flaborn954 Flaborn954 mentioned this pull request Mar 26, 2024
2 tasks
This was referenced Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest a wallet
4 participants