Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct example trie structure [Fixes #6860] #11850

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

lgaroche
Copy link
Contributor

@lgaroche lgaroche commented Jan 2, 2024

Description

  1. Minimal change (added a single byte to the (doge, coin) value) required to make the last node an extension node and not embedded.
  2. Renamed hashD to hashC and propagated the naming change.
  3. Suggested a change in the H(rlp.encode(x)) explanation to make it slightly clearer.

Related Issue

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 76872fd
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6626fcd58d974c0008daf848
😎 Deploy Preview https://deploy-preview-11850--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 29
Accessibility: 93
Best Practices: 92
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Jan 2, 2024
@lgaroche
Copy link
Contributor Author

lgaroche commented Jan 2, 2024

I suggested coins but any 5- or 6-letter word works.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @lgaroche!

@wackerow wackerow merged commit 29ff650 into ethereum:dev Apr 23, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Apr 23, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @lgaroche for content bug fixes

Copy link
Contributor

@wackerow

I've put up a pull request to add @lgaroche! 🎉

This was referenced Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HashE (node E) from the "Patricia Merkle Trie" example is embeddable
2 participants