Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German import #11976

Merged
merged 6 commits into from
Feb 13, 2024
Merged

German import #11976

merged 6 commits into from
Feb 13, 2024

Conversation

corwintines
Copy link
Member

Description

  • German import (Homepage, Essential Page, Use Ethereum, Use cases, Staking, Learn hub & guides, Roadmap, Community, Foundational docs, Foundational docs - nodes and clients)

@corwintines
German import (Homepage, Essential Page, Use Ethereum, Use cases, Sta…
b252275 
…king, Learn hub & guides, Roadmap, Community, Foundational docs, Foundational docs - nodes and clients)
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b31d6ed
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65ca9fb8213e9c00093990eb
😎 Deploy Preview https://deploy-preview-11976--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Jan 18, 2024
minimalsm
minimalsm reviewed Jan 25, 2024
View reviewed changes
public/content/translations/de/developers/docs/networks/index.md
- [Alchemy Sepolia-Faucet](https://sepoliafaucet.com/)
- [Infura Sepolia-Faucet](https://www.infura.io/faucet)
- [Chainstack Sepolia-Faucet](https://faucet.chainstack.com/sepolia-faucet)
- [Faucet für Coinbase-Wallet | Sepolia](https://coinbase.com/faucets/ethereum-sepolia-faucet)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of für here seems weird...

Literally "Faucet for Coinbase-Wallet"

@lukassim any thoughts?

minimalsm
minimalsm approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the changes I tagged @lukassim on here.

Not blocking this PR necessarily.

@wackerow wackerow merged commit a1a98c1 into dev Feb 13, 2024
6 checks passed
@wackerow wackerow deleted the germanImport branch February 13, 2024 18:56
This was referenced Feb 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@wackerow wackerow wackerow approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees

@lukassim lukassim

Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corwintines @wackerow @minimalsm @lukassim