-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates in gas docs and history docs #12008
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @Crosstons, thanks for the PR 💪 this is a long-needed change 😅 At a glance this looks good, but will defer to @wackerow on the history page |
Also, @lukassim, we'll be moving translated content from one page to another; am I right in thinking Crowdin will be able to handle this automatically? |
Yes, for all intents and purposes it doesn't matter much which file a piece of text is in or what the string ID in Crowdin is, all we might need to do is manually trigger a pre-translations and we're good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Crosstons, this is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Crosstons Thanks for the help here! It's not a huge deal, but if possible I'd prefer to keep the pattern of the other entries and try to pull this content out of the expandable card and weave it into the summary copy on the /history page.
Well thanks for the review, and I am working on this again and just so to confirm you are expecting the whole London upgrade section in the summary copy of london section above the London EIPS Expandable card without any redundant info right? |
@wackerow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Crosstons Thanks again!
Personally would love to see a little bit more adjusting here to fit this content into this page a little better, but this at least gets the content out of the dev docs and into a more historical context. Going to pull in and we can iterate from here, thanks!
Fixed #5660
This pull request addresses the content update for the issue Gas page on the Ethereum website, changes introduced by the London Upgrade and EIP-1559. The content now reflects the current state of Ethereum, providing users with up-to-date information on variable-sized blocks and the revised transaction fee mechanism. Historical details have been moved to the /history/ page, offering a more streamlined and relevant user experience.