Fix i18n links not having the locale in hrefs #12050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h links not having the locale in hrefs
pettinarip
requested review from
wackerow,
corwintines,
minimalsm and
nhsz
as code owners
github-actions
bot
added
dependencies 📦
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
corwintines
reviewed
Jan 31, 2024
src/lib/utils/cx.ts
Outdated
There was a problem hiding this comment.
I don't see this used anywhere, is this necessary?
There was a problem hiding this comment.
Ah, good catch. That was left over from a previous implementation. Let me remove it
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the user loads a page, all the internal navigation links display the
hrefwithout the locale that the user is using.For example, when you load https://ethereum.org/de/layer-2, all the internal links ignore the
delocale and build the href from the root level.Description
The problem seems to come from the
Linkcomponent imported from@chakra-ui/next-js. I'll try to reproduce this bug on a codesandbox later and open an issue in that repo.For the scope of this PR, it: