Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lazy-etherscan to the list of block explorers [Issue #12115] #12116

Merged
merged 2 commits into from
May 21, 2024

Conversation

woxjro
Copy link
Contributor

@woxjro woxjro commented Feb 5, 2024

Description

Add lazy-etherscan to the list of block explorers.

Related Issue

#12115

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 9fb6e3a
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/664d0ef62107570009fdcd49
😎 Deploy Preview https://deploy-preview-12116--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 9 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 93 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Feb 5, 2024
@wackerow
Copy link
Member

wackerow commented May 7, 2024

Hey @woxjro, very cool tool! Spun up super fast and love that I could point to my own node.

My main concern here would be it's location. This is very different from the others. I'm not against keeping it here, but I would suggest maybe a short subtext here related to be being a command-line tool. Thoughts?

Also wondering if this could be better fit in one of the pages on nodes... I see this as a nice add-on to anyone running their own RPC.

@woxjro
Copy link
Contributor Author

woxjro commented May 7, 2024

@wackerow
Thank you for your suggestion!

I would suggest maybe a short subtext here related to be being a command-line tool.

It sounds totally good!

wondering if this could be better fit in one of the pages on nodes...

I also agree with your idea!
Is it the following link you are talking about?
https://ethereum.org/en/developers/docs/nodes-and-clients/

I'm unsure where I have to put lazy-etherscan's link and the subtext, so if you tell me about that, I recreate PR!

@@ -25,6 +25,7 @@ You should understand the basic concepts of Ethereum so you can make sense of th
- [Sirato](https://www.web3labs.com/sirato)
- [EthVM](https://www.ethvm.com/)
- [DexGuru Block Explorer](https://ethereum.dex.guru/)
- [lazy-etherscan](https://github.com/woxjro/lazy-etherscan)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woxjro Can just add something here similar to language callouts.

Suggested change
- [lazy-etherscan](https://github.com/woxjro/lazy-etherscan)
- [lazy-etherscan](https://github.com/woxjro/lazy-etherscan) -_Command-line/terminal UI_

As I look at this again, it still feels awkward having this under "Services" since it's more of a tool the user can self-host, and tap into any RPC they'd like.

I'd suggest we create a new heading here for "Open source tools" perhaps, and place lazy-etherscan and Otterscan in there (and any others I may have missed that work similarly)

Suggested change
- [lazy-etherscan](https://github.com/woxjro/lazy-etherscan)
## Open source tools {#open-source-tools}
- [Otterscan](https://otterscan.io/)
- [lazy-etherscan](https://github.com/woxjro/lazy-etherscan)

(Then remove Otterscan from above list)

@wackerow
Copy link
Member

wackerow commented May 7, 2024

Also,

Is it the following link you are talking about?
https://ethereum.org/en/developers/docs/nodes-and-clients/

Yeah, loosely around that page though that one in particular is getting quite lengthy. Not sure we have a great place for "node add-ons" if-you-will.

@wackerow
Copy link
Member

wackerow commented May 7, 2024

...wouldn't include that in this PR though just to keep this one concise.

@woxjro woxjro force-pushed the patch/lazy-etherscan branch from d041783 to 8bb6910 Compare May 14, 2024 04:36
@woxjro woxjro force-pushed the patch/lazy-etherscan branch from 8bb6910 to e1d4ba3 Compare May 14, 2024 07:07
@woxjro
Copy link
Contributor Author

woxjro commented May 14, 2024

@wackerow
Thank you for your code suggestion!
I forcefully pushed a new commit, adding a heading about otterscan and lazy-etherscan.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @woxjro!

Unrelated to the PR, but just curious if there are future plans for lazy-etherscan, very cool lightweight software

@wackerow wackerow merged commit 5ede7d5 into ethereum:dev May 21, 2024
5 of 6 checks passed
Copy link

gitpoap-bot bot commented May 21, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @woxjro for tool

Copy link
Contributor

@wackerow

I've put up a pull request to add @woxjro! 🎉

This was referenced May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants