Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump Next to v14 with Netlify build Workaround #12266

Merged

Conversation

TylerAPfledderer
Copy link
Contributor

@TylerAPfledderer TylerAPfledderer commented Feb 22, 2024

Description

Upgrades NextJs to v14.

Two main changes added to avoid problems with the build:

  • Wrapped process.cwd() in a function, otherwise the Netlify runtime plugin would for some reason bundle the entire project folder, causing the deploy to fail due to size limits (250mb max).
  • Ignored deps and public folder from the deployed functions by using more specific syntax: [functions.{function-name}] instead of just [functions].

@github-actions github-actions bot added dependencies 📦 Changes related to project dependencies internal 🏠 labels Feb 22, 2024
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit c6095b5
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66333ee36ab1fe0008de4736
😎 Deploy Preview https://deploy-preview-12266--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🟢 up 8 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 89 (🔴 down 11 from production)
SEO: 95 (🔴 down 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

"node_modules/next/dist/server/future/route-modules/pages/vendored/contexts/amp-context*",
"node_modules/next/dist/server/future/route-modules/pages/vendored/contexts/head-manager-context*",
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerAPfledderer
Copy link
Contributor Author

@pettinarip Great! This is kinda insane to have to do all of that configuring. 😅

@pettinarip
Copy link
Member

@pettinarip Great! This is kinda insane to have to do all of that configuring. 😅

Yeah, right? all the nuances you have to deal with 🤷🏼 the cost of living on the edge :P

@pettinarip pettinarip merged commit e4e7cfb into ethereum:dev May 10, 2024
6 checks passed
@TylerAPfledderer TylerAPfledderer deleted the build/next-14-netlify-workaround branch May 10, 2024 15:34
This was referenced May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📦 Changes related to project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants