fix: fixed date format #12287
fix: fixed date format #12287
Conversation
ameeetgaikwad
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Hey @ameeetgaikwad! Thanks for the PR... as @nhsz mentioned, we do have some other related helper functions already in the codebase for this.. Left some suggestions as to how we could reuse these and get this cleaned up. Let us know if you hit issues!
src/lib/utils/date.ts
Outdated
| export const formatDate = (date: Date, locale: string): string => { | ||
| return Intl.DateTimeFormat(locale).format(date) | ||
| } |
There was a problem hiding this comment.
We have getLocaleTimestamp inside src/lib/utils/time.ts which does this same thing with a bit more flexibility and type safety (allowing display options to be passed for example).
I think we should remove this addition and use getLocaleTimestamp instead
There was a problem hiding this comment.
| export const formatDate = (date: Date, locale: string): string => { | |
| return Intl.DateTimeFormat(locale).format(date) | |
| } |
| ? formatDate(dateParse(event.startDate), locale) | ||
| : `${formatDate(dateParse(event.startDate), locale)} - ${formatDate( | ||
| dateParse(event.endDate), | ||
| locale | ||
| )}` |
There was a problem hiding this comment.
Would update this to use getLocaleTimestamp from time.ts... it accepts the locale, (of Lang type) then timestamp as a string (then optional options override argument which may be able to be left out here)
ie. getLocaleTimestamp(locale! as Lang, dateParse(event.startDate).getTime())
locale! force unwraps it, since we know we'll get a locale back from useRouter... and as Lang casts it to the expected type as defined inside getLocaleTimestamp.
^ With this, we need to fix the locale instantiation (see above), and also import Lang type above:
import type { CommunityConference, Lang } from "@/lib/types"
| @@ -19,6 +21,7 @@ type OrderedUpcomingEvent = CommunityConference & { | |||
| } | |||
|
|
|||
| const UpcomingEventsList = () => { | |||
| const { locale = "" } = useRouter() | |||
There was a problem hiding this comment.
| const { locale = "" } = useRouter() | |
| const { locale } = useRouter() |
| @@ -9,6 +10,7 @@ import EventCard from "@/components/EventCard" | |||
| import InfoBanner from "@/components/InfoBanner" | |||
| import InlineLink from "@/components/Link" | |||
|
|
|||
| import { formatDate } from "@/lib/utils/date" | |||
There was a problem hiding this comment.
| import { formatDate } from "@/lib/utils/date" |
|
Just pushed a commit to update this with the latest from |
|
This issue is stale because it has been open 30 days with no activity. |
|
@wackerow do you think this PR is still relevant? |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description
Created a function in src/lib/utils/date.ts which can be used to format dates in a certain format according to the language.
Related Issue
fixes #11335
closes #11443