Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public key infrastructure -> Public key cryptography #12453

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Mar 14, 2024

Description

  • Changes references of public key infrastructure to public key cryptography

Related Issue

Fixes #8608

Summary by CodeRabbit

  • Documentation
    • Updated terminology from "Public Key Infrastructure (PKI)" to "Public Key Cryptography" in the decentralized identity documentation to highlight the cryptographic aspect of key generation in blockchain networks.

Copy link
Contributor

coderabbitai bot commented Mar 14, 2024

Walkthrough

The overall change involves updating the terminology in the decentralized identity documentation from "Public Key Infrastructure (PKI)" to "Public Key Cryptography." This adjustment is made to better reflect the cryptographic processes of generating and managing public and private keys within blockchain networks and to avoid the misleading implications associated with traditional, centralized PKI systems.

Changes

Files Changed Summary of Changes
public/content/decentralized-identity/index.md Renamed "Public Key Infrastructure (PKI)" to "Public Key Cryptography" throughout.

Assessment against linked issues

Objective Addressed Explanation
Clarify the distinction between "Public-Key Infrastructure" and "Public-key cryptography" (#8608)
Address the misleading use of the term "PKI" in the documentation (#8608)
Ensure accurate reflection of the decentralized nature using public-key cryptography (#8608)
Update documentation to explain public-key cryptography in decentralized identity systems (#8608)
Provide clear information about cryptographic principles in decentralized identity systems (#8608)

This assessment confirms that all key objectives outlined in the linked issue #8608 have been successfully addressed in the code changes. The updated documentation now accurately distinguishes between PKI and public-key cryptography, avoids misleading terminology, reflects the decentralized nature of systems like Ethereum, and provides clear information about cryptographic principles, aligning with the goals set out in the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Mar 14, 2024
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit df35f4c
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65f3333d04b26400086b3a5e
😎 Deploy Preview https://deploy-preview-12453--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow merged commit b1d4f64 into dev Mar 14, 2024
2 checks passed
@wackerow wackerow deleted the pki-cryptography branch March 14, 2024 17:26
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 3d24dc7 and 74a1436.
Files selected for processing (1)
  • public/content/decentralized-identity/index.md (1 hunks)
Additional comments: 6
public/content/decentralized-identity/index.md (6)
  • 94-98: The update from "Public Key Infrastructure" to "Public Key Cryptography" in the section headers and content is consistent with the PR's objective to clarify the cryptographic processes involved in Ethereum's decentralized systems. This change accurately reflects the decentralized, cryptographic foundation of Ethereum's identity mechanisms, avoiding the connotations of centralization associated with traditional PKI systems.
  • 91-101: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The metadata section at the beginning of the file seems correctly formatted for a markdown file used in a website's content management system. The hint regarding the use of "en" appears to be a false positive, as "lang: en" correctly specifies the language of the document.

  • 91-101: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [22-22]

Consider varying the sentence structure or using synonyms to avoid repetitive sentence beginnings that could impact the readability of the document. This can enhance the flow and keep the reader engaged.

  • 91-101: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [22-22]

The spelling and grammar throughout the document appear to be correct, and the use of technical terms is appropriate for the context. The hints suggesting possible spelling mistakes seem to be false positives, likely due to the technical and domain-specific language used in the document.

  • 91-101: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [106-106]

The phrase "How do decentralized identifiers and attestations enable decentralized identity?" is correctly phrased to introduce the section. The hint suggesting the use of "decentralize" instead of "decentralized" in this context appears to be incorrect, as the sentence is asking about the role of decentralized identifiers and attestations.

  • 91-101: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [136-136]

Consider adding commas for clarity in sentences where they might enhance readability or correctly separate clauses. Additionally, when referring to people, using "who" instead of "that" can make the text more personable and clear.

Also applies to: 138-138, 146-146

Comment on lines 91 to 101

## What makes decentralized identifiers possible? {#what-makes-decentralized-identifiers-possible}

### 1. Public Key Infrastructure (PKI) {#public-key-infrastructure}
### 1. Public Key Cryptography {#public-key-cryptography}

Public-key infrastructure (PKI) is an information security measure that generates a [public key](/glossary/#public-key) and [private key](/glossary/#private-key) for an entity. Public-key [cryptography](/glossary/#cryptography) is used in blockchain networks to authenticate user identities and prove ownership of digital assets.
Public-key cryptography is an information security measure that generates a [public key](/glossary/#public-key) and [private key](/glossary/#private-key) for an entity. Public-key [cryptography](/glossary/#cryptography) is used in blockchain networks to authenticate user identities and prove ownership of digital assets.

Some decentralized identifiers, such as an Ethereum account, have public and private keys. The public key identifies the account's controller, while the private keys can sign and decrypt messages for this account. PKI provides proofs needed to authenticate entities and prevent impersonation and use of fake identities, using [cryptographic signatures](https://andersbrownworth.com/blockchain/public-private-keys/) to verify all claims.
Some decentralized identifiers, such as an Ethereum account, have public and private keys. The public key identifies the account's controller, while the private keys can sign and decrypt messages for this account. Public key cryptography provides proofs needed to authenticate entities and prevent impersonation and use of fake identities, using [cryptographic signatures](https://andersbrownworth.com/blockchain/public-private-keys/) to verify all claims.

### 2. Decentralized datastores {#decentralized-datastores}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [128-128]

In the context of "Here's an hypothetical scenario," the correct article to use before a word starting with a consonant sound is "a" rather than "an." Consider revising this to "Here's a hypothetical scenario."

- Here's an hypothetical scenario
+ Here's a hypothetical scenario

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 42

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 74a1436 and df35f4c.
Files selected for processing (27)
  • public/content/translations/ar/decentralized-identity/index.md (1 hunks)
  • public/content/translations/bn/decentralized-identity/index.md (1 hunks)
  • public/content/translations/cs/decentralized-identity/index.md (1 hunks)
  • public/content/translations/de/decentralized-identity/index.md (1 hunks)
  • public/content/translations/el/decentralized-identity/index.md (1 hunks)
  • public/content/translations/es/decentralized-identity/index.md (1 hunks)
  • public/content/translations/fa/decentralized-identity/index.md (1 hunks)
  • public/content/translations/fil/decentralized-identity/index.md (1 hunks)
  • public/content/translations/fr/decentralized-identity/index.md (1 hunks)
  • public/content/translations/hi/decentralized-identity/index.md (1 hunks)
  • public/content/translations/hu/decentralized-identity/index.md (1 hunks)
  • public/content/translations/id/decentralized-identity/index.md (1 hunks)
  • public/content/translations/it/decentralized-identity/index.md (1 hunks)
  • public/content/translations/ja/decentralized-identity/index.md (1 hunks)
  • public/content/translations/kn/decentralized-identity/index.md (1 hunks)
  • public/content/translations/ko/decentralized-identity/index.md (1 hunks)
  • public/content/translations/mr/decentralized-identity/index.md (1 hunks)
  • public/content/translations/nl/decentralized-identity/index.md (1 hunks)
  • public/content/translations/pl/decentralized-identity/index.md (1 hunks)
  • public/content/translations/pt-br/decentralized-identity/index.md (1 hunks)
  • public/content/translations/pt/decentralized-identity/index.md (1 hunks)
  • public/content/translations/ru/decentralized-identity/index.md (1 hunks)
  • public/content/translations/sr/decentralized-identity/index.md (1 hunks)
  • public/content/translations/tr/decentralized-identity/index.md (1 hunks)
  • public/content/translations/uk/decentralized-identity/index.md (1 hunks)
  • public/content/translations/zh-tw/decentralized-identity/index.md (1 hunks)
  • public/content/translations/zh/decentralized-identity/index.md (1 hunks)
Additional comments: 32
public/content/translations/zh-tw/decentralized-identity/index.md (2)
  • 54-54: Consider adding appropriate quantifiers between numerals and nouns to improve readability and clarity in the document. This is a common practice in Chinese to ensure the text flows smoothly and is easily understood by readers.
  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [124-124]

The phrase "良好的配合" might be more accurately expressed as "良好地配合" to adhere to grammatical conventions in Chinese, where an adverbial modifier should be used to modify a verb.

public/content/translations/ja/decentralized-identity/index.md (1)
  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [18-18]

The expression "ことができます" is used multiple times throughout the document to indicate the ability to perform various actions. While this is grammatically correct, consider simplifying the expression to make the text more concise and direct, especially in contexts where the ability to perform an action is clear without explicitly stating "ことができます".

For example, "管理することができます" can be simplified to "管理できます".

public/content/translations/ar/decentralized-identity/index.md (1)
  • 52-52: The change from "public key infrastructure (PKI)" to "public key cryptography" in the section title is appropriate given the context of decentralized identity systems. However, it's crucial to ensure that the Arabic translation accurately reflects the term "public key cryptography". Additionally, verify that this terminology change is consistently applied throughout the document to avoid confusion.
public/content/translations/fa/decentralized-identity/index.md (1)
  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [22-22]

Consider rephrasing sentences to avoid starting three consecutive sentences with similar words for improved readability and style. However, ensure that any changes maintain the original meaning and clarity of the content.

public/content/translations/bn/decentralized-identity/index.md (1)
  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-11]

Metadata is correctly formatted and includes all necessary information for the website's content management system.

public/content/translations/kn/decentralized-identity/index.md (3)
  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [94-94]

The term "ಸ್ವರ್ಮ್‍ನಂತಹ" might be a typographical error or a misunderstanding of the term "Swarm" related to decentralized storage. It's important to ensure technical terms are accurately represented.

Please verify the correct Kannada term for "Swarm" as it relates to decentralized storage technologies, and consider updating the document accordingly.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [112-112]

The term "NFTಗಳು" is mentioned in the context of soulbound tokens, which are non-transferable by nature. Ensure the explanation around soulbound tokens and their relationship to NFTs is clear to the reader.

Consider adding a brief explanation or a footnote about soulbound tokens and how they differ from traditional NFTs to enhance clarity.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The document metadata section does not start with an uppercase letter, which might be due to the language-specific formatting. However, it's important to maintain consistency in metadata formatting across documents.

Ensure metadata fields like title and description follow a consistent formatting rule, possibly starting with uppercase letters if applicable to the language.

public/content/translations/uk/decentralized-identity/index.md (6)
  • 54-54: There's a potential typographical error in the description of public key infrastructure. It's crucial to ensure the accuracy of technical terms and descriptions.

Please double-check the terminology and spelling to ensure clarity and correctness.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [126-126]

The term "Сивілли" might be misspelled or incorrectly used. It's important to use the correct terminology, especially when discussing security concepts.

Consider verifying the spelling and usage of terms related to security attacks to maintain the document's credibility.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [132-132]

The word "логіни" is marked as slang. While it's understandable in context, using more formal language could enhance the document's professionalism.

Consider using a more formal term for "logins" to align with the document's tone.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [163-163]

There's a missing space after a comma, which could affect the readability of the document.

Please add a space after the comma for consistency and readability.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [169-169]

A hyphen is used within a word where a dash might be more appropriate. This could lead to confusion or misinterpretation.

Consider using a dash to separate parts of the sentence correctly, enhancing readability.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [179-179]

The term "безкоштовних" is suggested to be replaced with "безплатний" for better language use.

Consider using "безплатний" instead of "безкоштовних" to align with recommended language practices.

public/content/translations/ru/decentralized-identity/index.md (6)
  • 52-52: The heading reference has been updated from "public-key-infrastructure" to "public-key-cryptography" to better reflect the cryptographic processes involved in Ethereum's decentralized systems. This change aligns with the PR objectives and addresses the concerns raised in issue Decentralized Identity documentation: Using the expression "PKI" is misleading #8608 regarding the misleading use of "PKI" in the context of decentralized identity documentation.
  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

Ensure the document starts with proper capitalization to maintain consistency and professionalism in documentation.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [18-18]

Consider adding a comma for clarity in phrases like "таких, как Ethereum" to improve the readability of the text.

  • 54-54: Remove the unnecessary space after the opening bracket in markdown links to ensure proper formatting.
  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [136-136]

The sentence starting with "Затем функция" should end with a period for consistency and to maintain the structure of the document.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [177-177]

Correct the grammatical structure to use the preposition "от" with the genitive case: "от Надера Дебита".

public/content/translations/pt/decentralized-identity/index.md (4)
  • 49-55: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [52-58]

The terminology change from "Public Key Infrastructure (PKI)" to "Public Key Cryptography" is correctly implemented in the document. This adjustment enhances the document's accuracy by more precisely describing the cryptographic underpinnings of decentralized identity on the Ethereum platform, aligning with the decentralized nature of blockchain systems. However, the AI-generated summary incorrectly states the change, which might cause confusion. The document now correctly reflects the intended terminology update.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The document's metadata section correctly sets up the page's properties. However, the static analysis hinted at a potential issue with capitalization after colons, which is not applicable here as the syntax follows YAML conventions for Markdown metadata. No action is needed.

  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [16-16]

The term "IPI" (Informações Pessoalmente Identificáveis) is correctly used, but it might be beneficial to spell out the acronym on its first use to ensure clarity for all readers.

Consider spelling out "IPI (Informações Pessoalmente Identificáveis)" the first time it is used in the document.

  • 52-52: The section heading correctly reflects the terminology change to "Public Key Cryptography". However, the static analysis tools flagged potential spelling issues within this section. Most of these flags seem to be false positives, as they relate to technical terms and names that are correctly used in the context of Ethereum and blockchain technology.
public/content/translations/nl/decentralized-identity/index.md (1)
  • 52-52: The heading reference has been updated from "Publieke sleutel-infrastructuur (PKI)" to "Publieke sleutel-cryptografie", aligning with the PR's objective to more accurately reflect the cryptographic processes involved in Ethereum's decentralized systems. This change is appropriate and improves the clarity of the documentation.
public/content/translations/hu/decentralized-identity/index.md (1)
  • 52-52: The terminology has been updated from "Nyilvánoskulcs-infrastruktúra (PKI)" to "Nyilvánoskulcs-kriptográfia" to better reflect the cryptographic processes involved in managing public and private keys within blockchain networks. This change aligns with the decentralized nature of Ethereum's systems and addresses the concerns raised in issue Decentralized Identity documentation: Using the expression "PKI" is misleading #8608 regarding the potential confusion with centralized PKI systems.
public/content/translations/el/decentralized-identity/index.md (1)
  • 49-55: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [22-22]

Please verify the use of lowercase letters at the beginning of sentences. In some contexts, this might be intentional or acceptable, but generally, sentences should start with a capital letter for consistency and readability.

public/content/translations/id/decentralized-identity/index.md (1)
  • 52-52: The term "Infrastruktur kunci publik (PKI)" has been correctly updated to "Kriptografi kunci publik" to align with the PR's objective of emphasizing cryptographic processes over infrastructure aspects in the context of decentralized identifiers. This change accurately reflects the decentralized nature of blockchain systems like Ethereum and avoids potential confusion with centralized PKI systems.
public/content/translations/fil/decentralized-identity/index.md (1)
  • 49-55: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [52-56]

The terminology change from "Public Key Infrastructure (PKI)" to "Public Key Cryptography" is correctly applied and explained, enhancing the document's accuracy in describing cryptographic processes in decentralized identity systems.

public/content/translations/de/decentralized-identity/index.md (2)
  • 52-52: The update from "Public Key Infrastructure (PKI)" to "Public Key Cryptography" in the heading is aligned with the PR objectives and addresses the concerns raised. Ensure that this terminology update is consistently applied throughout the document to accurately reflect the cryptographic processes involved in Ethereum's decentralized systems.
  • 49-55: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-182]

Please conduct a thorough review of the entire document to ensure that the terminology update from "Public Key Infrastructure (PKI)" to "Public Key Cryptography" is consistently applied throughout. This includes checking the body text for any instances of "PKI" or related terms and updating them as necessary to align with the new terminology. This will help maintain clarity and prevent any potential confusion for readers.

@@ -49,7 +49,7 @@ Gli identificativi decentralizzati sono memorizzati su libri mastri distribuiti

## Cosa rende possibili gli identificativi decentralizzati? {#what-makes-decentralized-identifiers-possible}

### 1. Infrastruttura a Chiave Pubblica (PKI) {#public-key-infrastructure}
### 1. Infrastruttura a Chiave Pubblica (PKI) {#public-key-cryptography}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading "Infrastruttura a Chiave Pubblica (PKI)" was supposed to be updated to emphasize "Public Key Cryptography" over "Public Key Infrastructure". However, the heading remains unchanged. This does not align with the PR's objective to update the terminology from "Public Key Infrastructure (PKI)" to "Public Key Cryptography".

- ### 1. Infrastruttura a Chiave Pubblica (PKI) {#public-key-cryptography}
+ ### 1. Crittografia a Chiave Pubblica {#public-key-cryptography}

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
### 1. Infrastruttura a Chiave Pubblica (PKI) {#public-key-cryptography}
### 1. Crittografia a Chiave Pubblica {#public-key-cryptography}

@@ -49,7 +49,7 @@ summaryPoint3: क्रिप्टो को धन्यवाद, उपय

## विकेन्द्रीकृत पहचानकर्ताओं को संभाव बनाने वाला क्या है? {#what-makes-decentralized-identifiers-possible}

### १ सार्वजनिक कुंजी इन्फ्रास्ट्रक्चर (PKI) {#public-key-infrastructure}
### १ सार्वजनिक कुंजी इन्फ्रास्ट्रक्चर (PKI) {#public-key-cryptography}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading "१ सार्वजनिक कुंजी इन्फ्रास्ट्रक्चर (PKI)" has been updated to reflect the shift from "public key infrastructure" to "public key cryptography". However, the heading still contains "PKI" which contradicts the PR's objective. It should be updated to accurately reflect the new terminology.

- ### १ सार्वजनिक कुंजी इन्फ्रास्ट्रक्चर (PKI) {#public-key-cryptography}
+ ### १ सार्वजनिक कुंजी क्रिप्टोग्राफी {#public-key-cryptography}

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
### १ सार्वजनिक कुंजी इन्फ्रास्ट्रक्चर (PKI) {#public-key-cryptography}
### १ सार्वजनिक कुंजी क्रिप्टोग्राफी {#public-key-cryptography}

@@ -49,7 +49,7 @@ Decentralizované identifikátory jsou uloženy v distribuovaných účetních k

## Co umožňuje decentralizované identifikátory? {#what-makes-decentralized-identifiers-possible}

### 1. Infrastruktura veřejných klíčů (PKI) {#public-key-infrastructure}
### 1. Infrastruktura veřejných klíčů (PKI) {#public-key-cryptography}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section title and content still refer to "Infrastruktura veřejných klíčů (PKI)" which contradicts the PR's objective to update the terminology to "Public Key Cryptography". To align with the PR objectives and improve clarity, the terminology should be updated throughout the document, including the section title and any references within the text.

- Infrastruktura veřejných klíčů (PKI)
+ Kryptografie veřejných klíčů

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
### 1. Infrastruktura veřejných klíčů (PKI) {#public-key-cryptography}
### 1. Kryptografie veřejných klíčů {#public-key-cryptography}

@@ -49,7 +49,7 @@ Zdecentralizowane identyfikatory są przechowywane w rozproszonych księgach (ł

## Co sprawia, że zdecentralizowane identyfikatory są możliwe? {#what-makes-decentralized-identifiers-possible}

### 1. Infrastruktura klucza publicznego (PKI) {#public-key-infrastructure}
### 1. Infrastruktura klucza publicznego (PKI) {#public-key-cryptography}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section title "Infrastruktura klucza publicznego (PKI)" has been updated to "Infrastruktura klucza publicznego (PKI)" according to the AI-generated summary. However, it seems there was an oversight, as the change does not reflect the intended update from "Public Key Infrastructure (PKI)" to "Public Key Cryptography". The correct term in Polish for "Public Key Cryptography" would be "Kryptografia klucza publicznego". This change is crucial for aligning the terminology with the actual cryptographic processes involved in decentralized identity systems on the Ethereum platform.

- Infrastruktura klucza publicznego (PKI)
+ Kryptografia klucza publicznego

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
### 1. Infrastruktura klucza publicznego (PKI) {#public-key-cryptography}
### 1. Kryptografia klucza publicznego {#public-key-cryptography}

@@ -49,7 +49,7 @@ Merkeziyetsiz tanımlayıcılar dağıtık defterlerde (blok zincirler) veya eş

## Merkeziyetsiz tanımlayıcıları mümkün kılan nedir? {#what-makes-decentralized-identifiers-possible}

### 1. Açık Anahtar Altyapısı (AAA) {#public-key-infrastructure}
### 1. Açık Anahtar Altyapısı (AAA) {#public-key-cryptography}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terminology change from "Açık Anahtar Altyapısı (AAA)" to "Açık Anahtar Kriptografisi" is appropriate and aligns with the PR objectives. However, there's a minor inconsistency in capitalization within the text. It's recommended to maintain consistency in the usage of terms, especially in a document that's likely to be referenced for technical clarity.

- Açık Anahtar altyapısı (AAA)
+ Açık Anahtar Altyapısı (AAA)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
### 1. Açık Anahtar Altyapısı (AAA) {#public-key-cryptography}
### 1. Açık Anahtar Altyapısı (AAA) {#public-key-cryptography}

@@ -49,7 +49,7 @@

## چه چیزی شناسه های غیرمتمرکز را ممکن می کند? {#what-makes-decentralized-identifiers-possible}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider revising the punctuation mark "?" to the correct Farsi question mark "؟" for consistency with Farsi typography.

- چیزی شناسه های غیرمتمرکز را ممکن می کند?
+ چیزی شناسه های غیرمتمرکز را ممکن می کند؟

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
## چه چیزی شناسه های غیرمتمرکز را ممکن می کند? {#what-makes-decentralized-identifiers-possible}
## چه چیزی شناسه های غیرمتمرکز را ممکن می کند؟ {#what-makes-decentralized-identifiers-possible}

@@ -49,7 +49,7 @@

## چه چیزی شناسه های غیرمتمرکز را ممکن می کند? {#what-makes-decentralized-identifiers-possible}

### 1. زیرساخت کلید عمومی (PKI) {#public-key-infrastructure}
### 1. زیرساخت کلید عمومی (PKI) {#public-key-cryptography}

زیرساخت کلید عمومی (PKI) یک اقدام امنیتی اطلاعاتی است که یک [کلید عمومی](/glossary/#public-key) و [ ایجاد می‌کند. کلید خصوصی](/glossary/#private-key) برای یک موجودیت. رمزنگاری کلید عمومی در شبکه های بلاک چین برای احراز هویت کاربران و اثبات مالکیت دارایی های دیجیتال استفاده می شود.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be a space after the opening bracket. This is a minor typographical issue but important for consistency and readability.

- [کلید عمومی](/glossary/#public-key) و [ ایجاد می‌کند.
+ [کلید عمومی](/glossary/#public-key) و [ایجاد می‌کند.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
زیرساخت کلید عمومی (PKI) یک اقدام امنیتی اطلاعاتی است که یک [کلید عمومی](/glossary/#public-key) و [ ایجاد می‌کند. کلید خصوصی](/glossary/#private-key) برای یک موجودیت. رمزنگاری کلید عمومی در شبکه های بلاک چین برای احراز هویت کاربران و اثبات مالکیت دارایی های دیجیتال استفاده می شود.
زیرساخت کلید عمومی (PKI) یک اقدام امنیتی اطلاعاتی است که یک [کلید عمومی](/glossary/#public-key) و [ایجاد می‌کند. کلید خصوصی](/glossary/#private-key) برای یک موجودیت. رمزنگاری کلید عمومی در شبکه های بلاک چین برای احراز هویت کاربران و اثبات مالکیت دارایی های دیجیتال استفاده می شود.

@@ -49,7 +49,7 @@ summaryPoint3: Χάρη στα κρυπτονομίσματα, οι χρήστε

## Τι καθιστά τα αποκεντρωμένα αναγνωριστικά υλοποιήσιμα; {#what-makes-decentralized-identifiers-possible}

### 1. Υποδομή Δημόσιου Κλειδιού (PKI) {#public-key-infrastructure}
### 1. Υποδομή Δημόσιου Κλειδιού (PKI) {#public-key-cryptography}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section title "Υποδομή Δημόσιου Κλειδιού (PKI)" should be updated to reflect the intended change to "Public Key Cryptography". This aligns with the PR's objective to more accurately describe the cryptographic processes involved.

- ### 1. Υποδομή Δημόσιου Κλειδιού (PKI) {#public-key-cryptography}
+ ### 1. Κρυπτογραφία Δημόσιου Κλειδιού {#public-key-cryptography}

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
### 1. Υποδομή Δημόσιου Κλειδιού (PKI) {#public-key-cryptography}
### 1. Κρυπτογραφία Δημόσιου Κλειδιού {#public-key-cryptography}

Comment on lines 49 to 55

## Τι καθιστά τα αποκεντρωμένα αναγνωριστικά υλοποιήσιμα; {#what-makes-decentralized-identifiers-possible}

### 1. Υποδομή Δημόσιου Κλειδιού (PKI) {#public-key-infrastructure}
### 1. Υποδομή Δημόσιου Κλειδιού (PKI) {#public-key-cryptography}

Το Public-key infrastructure (PKI) είναι ένα μέτρο ασφάλειας πληροφοριών που δημιουργεί ένα [δημόσιο κλειδί](/glossary/#public-key) και [ ένα ιδιωτικό κλειδί](/glossary/#private-key) για μια οντότητα. Η κρυπτογραφία δημόσιου κλειδιού χρησιμοποιείται σε δίκτυα blockchain για τον έλεγχο ταυτότητας των χρηστών και την απόδειξη της ιδιοκτησίας των ψηφιακών τους στοιχείων.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [16-16]

There's an unnecessary space after the opening bracket in the link. Ensure there are no spaces between the bracket and the link text for proper Markdown formatting.

- και [ τις βεβαιώσεις σας](#what-are-attestations)
+ και [τις βεβαιώσεις σας](#what-are-attestations)

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [152-152]

There's an unnecessary space after the opening bracket in the link. Ensure there are no spaces between the bracket and the link text for proper Markdown formatting.

- χρησιμοποιούν [ την τετραγωνική ψηφοφορία](https://www.radicalxchange.org/concepts/plural-voting/)
+ χρησιμοποιούν [την τετραγωνική ψηφοφορία](https://www.radicalxchange.org/concepts/plural-voting/)

@@ -49,7 +49,7 @@

## Τι καθιστά τα αποκεντρωμένα αναγνωριστικά υλοποιήσιμα; {#what-makes-decentralized-identifiers-possible}

### 1. Υποδομή Δημόσιου Κλειδιού (PKI) {#public-key-infrastructure}
### 1. Υποδομή Δημόσιου Κλειδιού (PKI) {#public-key-cryptography}

Το Public-key infrastructure (PKI) είναι ένα μέτρο ασφάλειας πληροφοριών που δημιουργεί ένα [δημόσιο κλειδί](/glossary/#public-key) και [ ένα ιδιωτικό κλειδί](/glossary/#private-key) για μια οντότητα. Η κρυπτογραφία δημόσιου κλειδιού χρησιμοποιείται σε δίκτυα blockchain για τον έλεγχο ταυτότητας των χρηστών και την απόδειξη της ιδιοκτησίας των ψηφιακών τους στοιχείων.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an unnecessary space after the opening bracket in the link. Ensure there are no spaces between the bracket and the link text for proper Markdown formatting.

- και [ ένα ιδιωτικό κλειδί](/glossary/#private-key)
+ και [ένα ιδιωτικό κλειδί](/glossary/#private-key)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
Το Public-key infrastructure (PKI) είναι ένα μέτρο ασφάλειας πληροφοριών που δημιουργεί ένα [δημόσιο κλειδί](/glossary/#public-key) και [ ένα ιδιωτικό κλειδί](/glossary/#private-key) για μια οντότητα. Η κρυπτογραφία δημόσιου κλειδιού χρησιμοποιείται σε δίκτυα blockchain για τον έλεγχο ταυτότητας των χρηστών και την απόδειξη της ιδιοκτησίας των ψηφιακών τους στοιχείων.
Το Public-key infrastructure (PKI) είναι ένα μέτρο ασφάλειας πληροφοριών που δημιουργεί ένα [δημόσιο κλειδί](/glossary/#public-key) και [ένα ιδιωτικό κλειδί](/glossary/#private-key) για μια οντότητα. Η κρυπτογραφία δημόσιου κλειδιού χρησιμοποιείται σε δίκτυα blockchain για τον έλεγχο ταυτότητας των χρηστών και την απόδειξη της ιδιοκτησίας των ψηφιακών τους στοιχείων.

This was referenced Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decentralized Identity documentation: Using the expression "PKI" is misleading
2 participants