Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Everstake to staking pools [Closes #11825] #12469

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Mar 15, 2024

Description

Preview link

Related Issue

cc: @irina-everstake @omykhailovskyi

Summary by CodeRabbit

  • New Features
    • Introduced the EverstakeGlyphIcon for enhanced visual representation in the staking section.

Copy link
Contributor

coderabbitai bot commented Mar 15, 2024

Walkthrough

This update introduces a new component, EverstakeGlyphIcon, designed for representing Everstake in an iconographic form. Additionally, it ensures that this new icon is properly exported for use within the broader project. This change is part of an effort to include Everstake's ETH staking services on ethereum.org, highlighting its features, security measures, and operational details to a wider audience.

Changes

File Path Change Summary
src/components/icons/staking/EverstakeGlyphIcon.tsx Introduced EverstakeGlyphIcon component.
src/components/icons/staking/index.ts Added export of EverstakeGlyphIcon.

Assessment against linked issues

Objective Addressed Explanation
Request Inclusion on ethereum.org (#11825) The code changes do not directly address the listing of Everstake on ethereum.org, as this requires additional non-coding actions.
Provide Information for Inclusion (#11825) The PR focuses on codebase changes without including detailed information about Everstake's ETH staking solution.
Highlight Security Measures (#11825) Security audit details are not covered in the code changes.
Describe Operational Details (#11825) The PR does not contain information on operational details such as node operation or reward distribution.
Provide Client Distribution Information (#11825) Client distribution percentages and preferences are not mentioned in the code changes.
Share Social Media Links (#11825) Social media links are not included in the PR, as it focuses solely on the introduction of a new icon component.

The code changes primarily introduce a new icon component and its export, which does not directly address the key objectives outlined in the linked GitHub issue regarding the inclusion of Everstake on ethereum.org. The objectives are more aligned with content and information sharing, which are not achievable through the submitted code changes alone.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2eaeea9
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65f49496904ddf0009259a15
😎 Deploy Preview https://deploy-preview-12469--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 90e4310 and 2eaeea9.
Files ignored due to path filters (1)
  • src/data/staking-products.json is excluded by: !**/*.json
Files selected for processing (2)
  • src/components/icons/staking/EverstakeGlyphIcon.tsx (1 hunks)
  • src/components/icons/staking/index.ts (1 hunks)
Additional comments: 2
src/components/icons/staking/index.ts (1)
  • 16-16: The addition of EverstakeGlyphIcon export aligns well with the existing pattern and the PR's objective to integrate Everstake into the ethereum.org platform. Looks good to me.
src/components/icons/staking/EverstakeGlyphIcon.tsx (1)
  • 1-14: The EverstakeGlyphIcon component is well-structured and correctly utilizes Chakra UI's createIcon function. The SVG path is appropriately included, and the component's properties are correctly set. This addition supports the PR's objective to visually integrate Everstake into the ethereum.org platform effectively.

@wackerow wackerow merged commit 8ddce8e into dev Mar 21, 2024
10 checks passed
@wackerow wackerow deleted the everstake-listing branch March 21, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion to list Everstake 0.1+ ETH staking on ethereum.org under a staking pool category
2 participants