-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead sepolia faucet - https://testnet-faucet.com/sepolia/ #12477
Conversation
The Sepolia faucet doesn't work and the link leads nowhere
WalkthroughThe update involves removing a specific resource link for the Sepolia network from a documentation page. Specifically, the link to the Testnet Faucet for Sepolia has been taken out from a list that provides users with various faucets for network testing purposes. This change streamlines the resource list, possibly due to the faucet's deprecation or a decision to narrow down the recommended resources. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- public/content/developers/docs/networks/index.md (1 hunks)
Additional comments: 1
public/content/developers/docs/networks/index.md (1)
- 61-66: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [57-64]
The removal of the non-functional Sepolia testnet faucet link is appropriate given the context that it has been non-operational since 2023. This change helps maintain the accuracy and reliability of the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ayofimihan! I just pushed a commit to remove this link from the non-English pages as well. Pulling in!
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
@all-contributors please add @ayofimihan for bug fix |
I've put up a pull request to add @ayofimihan! 🎉 |
The Sepolia faucet doesn't work and the link leads nowhere
Summary by CodeRabbit