Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead sepolia faucet - https://testnet-faucet.com/sepolia/ #12477

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

ayofimihan
Copy link
Contributor

@ayofimihan ayofimihan commented Mar 17, 2024

The Sepolia faucet doesn't work and the link leads nowhere

Summary by CodeRabbit

  • Documentation
    • Removed the Testnet Faucet | Sepolia link from the Sepolia network documentation.

The Sepolia faucet doesn't work and the link leads nowhere
Copy link
Contributor

coderabbitai bot commented Mar 17, 2024

Walkthrough

The update involves removing a specific resource link for the Sepolia network from a documentation page. Specifically, the link to the Testnet Faucet for Sepolia has been taken out from a list that provides users with various faucets for network testing purposes. This change streamlines the resource list, possibly due to the faucet's deprecation or a decision to narrow down the recommended resources.

Changes

Files Change Summary
public/content/.../networks/index.md Removed the Testnet Faucet

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Mar 17, 2024
Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit eb15c15
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65fb258dd0bebc0008cf3f08
😎 Deploy Preview https://deploy-preview-12477--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between dd0f529 and deae2d0.
Files selected for processing (1)
  • public/content/developers/docs/networks/index.md (1 hunks)
Additional comments: 1
public/content/developers/docs/networks/index.md (1)
  • 61-66: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [57-64]

The removal of the non-functional Sepolia testnet faucet link is appropriate given the context that it has been non-operational since 2023. This change helps maintain the accuracy and reliability of the documentation.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayofimihan! I just pushed a commit to remove this link from the non-English pages as well. Pulling in!

@wackerow wackerow merged commit bfb7570 into ethereum:dev Mar 20, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Mar 20, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @ayofimihan for bug fix

Copy link
Contributor

@wackerow

I've put up a pull request to add @ayofimihan! 🎉

This was referenced Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants