Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Covalent Python and Typescript SDK info on docs page #12585

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

Dennayz
Copy link
Contributor

@Dennayz Dennayz commented Mar 27, 2024

Description

The PR intends to describe Covalent's SDK packages (Python and TypeScript) and our backend API under the respectable documentation sections. This will go along with the recent covalent Golang SDK PR #12543.

Related Issue

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Mar 27, 2024
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b128b49
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6670c50aac6d7a0008809634
😎 Deploy Preview https://deploy-preview-12585--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 43 (🟢 up 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow self-assigned this Apr 8, 2024
@wackerow wackerow added the needs product review 🕵️ Product listing request in need of review label Apr 8, 2024
@wackerow
Copy link
Member

wackerow commented Apr 8, 2024

Thanks @Dennayz! Flagged for product review

@Dennayz
Copy link
Contributor Author

Dennayz commented Apr 10, 2024

Thanks @Dennayz! Flagged for product review

Thanks! I also fixed the merge conflict! :)

@Dennayz
Copy link
Contributor Author

Dennayz commented Apr 17, 2024

@wackerow Hey! Just wondering if there are any updates on this? Thanks!

@wackerow
Copy link
Member

wackerow commented May 7, 2024

Hey @Dennayz, question.. was checking out https://www.npmjs.com/package/@covalenthq/client-sdk and tried to look at the repo but it 404's.. has it moved or is it closed?

@wackerow wackerow added the question ❓ Further information is requested label May 7, 2024
@Dennayz
Copy link
Contributor Author

Dennayz commented May 7, 2024

Hey @Dennayz, question.. was checking out https://www.npmjs.com/package/@covalenthq/client-sdk and tried to look at the repo but it 404's.. has it moved or is it closed?

Hey @wackerow, thanks for the reply! I think the repo is private.

@wackerow
Copy link
Member

Thanks @Dennayz.. curious if you know if there are plans to open source the SDK in the future? To my knowledge the other JS and Python products on two of the pages here are all open source. We could probably add this to the frameworks page, but hesitant to open the others up to closed source.
cc: @minimalsm @corwintines curious if you have an opinion here

@Dennayz
Copy link
Contributor Author

Dennayz commented May 27, 2024

Thanks @Dennayz.. curious if you know if there are plans to open source the SDK in the future? To my knowledge the other JS and Python products on two of the pages here are all open source. We could probably add this to the frameworks page, but hesitant to open the others up to closed source. cc: @minimalsm @corwintines curious if you have an opinion here

Hey @wackerow, thanks for the message, I do not think these SDK's will be open sourced anytime soon.

@wackerow
Copy link
Member

wackerow commented Jun 7, 2024

@Dennayz Thoughts on starting with a listing on the Frameworks page only for this, given the open source aspect of the JS/Python lists?

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed from JS and Python pages at least for now, but left in for the frameworks page. Thanks @Dennayz! Bringing in

@wackerow wackerow merged commit b8a9b3f into ethereum:dev Jun 17, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Jun 17, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @Dennayz for tool

Copy link
Contributor

@wackerow

I've put up a pull request to add @Dennayz! 🎉

This was referenced Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits needs product review 🕵️ Product listing request in need of review question ❓ Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants