Fix Tooltip overwritten prop

[pettinarip]

Description

Avoids the overwriting of the prop onOpen and calls it after it is handled internally.

Related Issue

Fixes #12592

[netlify]

✅ Deploy Preview for ethereumorg ready!

Name	Link
🔨 Latest commit	a841cc3
🔍 Latest deploy log	https://app.netlify.com/sites/ethereumorg/deploys/660541c1c590850008e9d768
😎 Deploy Preview	https://deploy-preview-12594--ethereumorg.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[TylerAPfledderer]

Hey @pettinarip !

I see this working fine to address the hover issue. I will point out that it is breaking the AlwaysOpen story; essentially losing the intended snapshot of the tooltip on open which creates a regression.

If it can no longer accept the isOpen from the outside, can just accept the regression and look to add it to my PR that adds interaction testing with the play feature.

[pettinarip]

Hey @pettinarip !

I see this working fine to address the hover issue. I will point out that it is breaking the AlwaysOpen story; essentially losing the intended snapshot of the tooltip on open which creates a regression.

If it can no longer accept the isOpen from the outside, can just accept the regression and look to add it to my PR that adds interaction testing with the play feature.

No. This is a great catch from the Storybook tests. I think we should keep that flexibility. I've fixed this reverting the changes and adding a new prop onBeforeOpen that lets you do whatever you need on this event.

[wackerow]

Thanks @pettinarip! And thank you @TylerAPfledderer for the help reviewing!