Fix: component padding on /stablecoins #12659
Conversation
Dharmik79
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
changed the title
src/pages/stablecoins.tsx
Outdated
| @@ -614,7 +614,7 @@ const StablecoinsPage = ({ markets, marketsHasError }) => { | |||
| <InfoBanner emoji="⚠️" isWarning> | |||
There was a problem hiding this comment.
I would suggest we place this on the InfoBanner as a margin bottom instead:
| <InfoBanner emoji="⚠️" isWarning> | |
| <InfoBanner emoji="⚠️" isWarning mb="4"> |
Also @konopkja, does 1rem look like enough here for you? The padding in the info banner and the margin between it and the header is 1.5rem for reference
wackerow
added
the
needs design approval 🧑🎨
There was a problem hiding this comment.
Small enough patch, I think this looks good and doesn't need to be blocked. Thanks @Dharmik79!
@konopkja if you want to adjust the amount just drop a message and we can update it separately.
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
@all-contributors please add @Dharmik79 for bug fix |
|
I've put up a pull request to add @Dharmik79! 🎉 |
Description
Added the padding between the warning and the text [Fixes #12649 ]
Preview link
https://deploy-preview-12659--ethereumorg.netlify.app/en/stablecoins
Related issue