Update translator acknowledgements #12684
Conversation
Replace POAPs with OATs
Replace POAPs with OATs
lukassim
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| <ContentHeading | ||
| as="h2" | ||
| fontSize={{ base: "2xl", md: "2rem" }} | ||
| fontWeight={600} | ||
| > | ||
| {t( | ||
| "page-contributing-translation-program-acknowledgements-poaps-title" | ||
| "page-contributing-translation-program-acknowledgements-oats-title" |
There was a problem hiding this comment.
We end up with a weird case here... The above .json string changes are in the English files only... we changed this string name, but this doesn't exist in other languages yet, so it falls back to the English "OATs"... but the other strings do exists in those langs and have the old copy.
I'd suggest we update this string key in all languages as well, which will display POAP along with everything else in there until these get translated.
There was a problem hiding this comment.
Good point, though I'd argue OAT shouldn't be translated anyway, same as with POAP
But yeah, there's still mention of POAP in all the subsequent text...
There was a problem hiding this comment.
One thing to note is that this page doesn't get that many views even in English, and even less in other languages, so I'd also be fine with keeping it this way until the new copy gets translated
There was a problem hiding this comment.
Hah okay... I just went ahead and fixed that key so the non-English pages will just be consistently not yet updated... the updates will then trickle down in cohesive chunks at least... and like you said, not a lot of eyes.
Description
Update the Translation Program and translation acknowledgement pages to replace the mentions of POAPs with OATs and update the process to claim them
Related Issue
No related issue