Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Crowdin generateReviewReport script #12738

Merged
merged 8 commits into from
Apr 30, 2024
Merged

feat: Crowdin generateReviewReport script #12738

merged 8 commits into from
Apr 30, 2024

Conversation

wackerow
Copy link
Member

Description

  • Adds wordsNeedingReview.ts report generation script
  • Exports a CSV with summary of all languages and content buckets that are fully translated but still have words that need final approval
  • CSV report is git ignored and intended to be added manually to any spreadsheet
  • Adds instructions for use and how to generate the appropriate API key

Related Issue

Crowdin CI/CD efforts

cc: @lukassim

@github-actions github-actions bot added dependencies 📦 Changes related to project dependencies needs review 👀 labels Apr 15, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 15, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit ab3a828
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/662fff835626ce00088ae29d
😎 Deploy Preview https://deploy-preview-12738--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 29 (🔴 down 10 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow mentioned this pull request Apr 16, 2024
Merged
2 tasks
minimalsm
minimalsm approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a nitpick on potential naming file/script, LGTM.

src/scripts/crowdin/reports/wordsNeedingReview.ts Outdated Show resolved Hide resolved
@wackerow @minimalsm
style: use semantic naming
cf64955 
Co-Authored-By: Joshua <62268199+minimalsm@users.noreply.github.com>
@wackerow wackerow requested a review from lukassim April 23, 2024 22:58
@wackerow wackerow mentioned this pull request Apr 23, 2024
Merged
@wackerow wackerow changed the title feat: add Crowdin "words needing review" report feat: add Crowdin script generateReviewReport Apr 23, 2024
@wackerow wackerow changed the title feat: add Crowdin script generateReviewReport feat: Crowdin generateReviewReport script Apr 23, 2024
lukassim
lukassim approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@lukassim lukassim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming this works for me, following the instructions you added to the generateReviewReport doc

@wackerow
feat: add dispatchable workflow
6498177 
saves results as action artifact
@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Apr 29, 2024
@corwintines corwintines self-assigned this Apr 30, 2024
@wackerow wackerow merged commit 0a497f8 into dev Apr 30, 2024
6 checks passed
@wackerow wackerow deleted the crowdin-reports branch April 30, 2024 05:42
This was referenced May 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@lukassim lukassim lukassim approved these changes

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees

@corwintines corwintines

Labels
dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wackerow @corwintines @lukassim @minimalsm