Add Lighthouse CI Action #12772
Add Lighthouse CI Action #12772
Conversation
minimalsm
requested review from
wackerow,
corwintines,
pettinarip and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
90 minute timeout on preview deploy
|
@minimalsm nice! Do you know an easy way to access these reports? or entering the job and downloading the zip file is the only way? Comparing it with the Netlify plugin, this point seems to be an important one. On Netlify, you have this pretty comment with a quick summary and a quick access link to the report. On the other hand, the CI action seems to be more flexible and powerful if we would like to do more things on top of it, we could combine it with other actions. (they have a nice example under "Use Do you have other pros & cons? Note: in the meanwhile, I'll add the same pages we are testing here on the Netlify plugin to see how it looks. |
|
Converting to draft.
|
Lighthouse scores are calculated based on the latest audit results |
| state: open | ||
| - name: Add Lighthouse stats as comment | ||
| id: comment_to_pr | ||
| uses: marocchino/sticky-pull-request-comment@v2.0.0 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| const links = ${{ steps.lighthouse_audit.outputs.links }}; | ||
| const formatResult = (res) => Math.round((res * 100)); | ||
|
|
||
| console.log('Total manifests:', manifests.length); |
There was a problem hiding this comment.
Total manifests should be number of runs * number of urls
There was a problem hiding this comment.
LGTM! nice job @minimalsm
After removing the testing branch, I think we are good to go.
Description
Trying Lighthouse CI for performance testing.
Related Issue
Performance testing
Summary by CodeRabbit