Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: merge/bc shipped banner #12833

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: merge/bc shipped banner #12833

merged 1 commit into from
Apr 25, 2024

Conversation

wackerow
Copy link
Member

Description

  • fix intl ns prefix
  • add isShipped to all merge/beacon chain callouts

Related Issue

Discovered during QA

@wackerow
fix: merge/bc shipped banner
26b23cd 
fix intl ns prefix
@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Apr 24, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 26b23cd
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66292f919b440700080f8236
😎 Deploy Preview https://deploy-preview-12833--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 30
Accessibility: 93
Best Practices: 92
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines changed the base branch from dev to staging April 24, 2024 16:14
@corwintines corwintines mentioned this pull request Apr 24, 2024
Closed
@corwintines corwintines changed the base branch from staging to dev April 25, 2024 15:05
@corwintines corwintines merged commit ff8f1bd into dev Apr 25, 2024
6 checks passed
@corwintines corwintines deleted the merge-shipped branch April 25, 2024 15:05
This was referenced May 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wackerow @corwintines