docs(applying-storybook): update documentation and usage #12837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerAPfledderer
force-pushed
the
refactor/applying-storybook-doc-update
branch
from
8bb0e32 to
1c9f6ad
Compare
pettinarip
reviewed
Apr 29, 2024
TylerAPfledderer
requested review from
wackerow,
corwintines,
minimalsm and
nhsz
as code owners
pettinarip
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Great @TylerAPfledderer, lgtm!
Will wait for @corwintines review in case we are missing something.
corwintines
reviewed
May 7, 2024
corwintines
approved these changes
May 7, 2024
There was a problem hiding this comment.
Left one suggestion, but don't think it needs to block merging. Nice one @TylerAPfledderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As essentially task #0 in rolling out new initiatives in including more component stories, this PR updates and adds clarification to the
Applying Storybookdocumentation for contributors.This also updates existing stories to ensure they are inline with this updated documentation.