Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mobile menu layout #12857

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix mobile menu layout #12857

merged 1 commit into from
Apr 29, 2024

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented Apr 29, 2024 •
edited
Loading

Description

Fixes mobile menu layout to have 3 columns instead of 2.

Related

Fixes #12856

@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 4d89a37
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/662f90313dc857000733e48a
😎 Deploy Preview https://deploy-preview-12857--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 29 (🔴 down 10 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nhsz
nhsz approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhsz nhsz merged commit 079fd66 into dev Apr 29, 2024
10 checks passed
@nhsz nhsz deleted the fix-mobile-menu-layout branch April 29, 2024 13:44
This was referenced May 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhsz nhsz nhsz approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile menu is broken
2 participants
@pettinarip @nhsz