-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Heading): create a wrapper for default sizes #12901
feat(Heading): create a wrapper for default sizes #12901
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@pettinarip curious here: it looks like all or most of the instances of the Chakra Heading component used in prod are explicitly defining a I take it this in intentional until the components they are a part of are update or replaced for the DS, correct? I have not touched them here. |
@coderabbitai review |
WalkthroughThese updates focus on streamlining the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
src/components/Heading/index.tsx (1)
22-28
: The documentation clearly explains the purpose and functionality of theHeading
component. Consider adding more detail about the default behavior when theas
prop is not provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @TylerAPfledderer! Thanks!
Recreates a
Heading
wrapper component to set defaultsize
token values based on the heading element supplied through theas
prop.Summary by CodeRabbit
New Features
Heading
wrapper component that automatically assigns size theme tokens based on the heading tag used.Refactor
Heading.stories.tsx
and enhanced usage by directly passing required props.Documentation
HeadingComponent
.