refactor: replace @chakra-ui/addon with local setup
#12944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
dependencies 📦
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerAPfledderer
force-pushed
the
refactor/localize-chakra-sb-addon
branch
from
4d55e67 to
9e6d5ce
Compare
pettinarip
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thanks for digging into this issue and adding the context of what is going on @TylerAPfledderer.
LGTM and rtl is working as expected after this change 👍🏼
|
@pettinarip should I add a story mode for Farsi here to be absolutely sure? |
Aren't you covering that on the other PR related to story modes? Same for me but yes, a specific test for that locale to test RTL would be really helpful. |
This was referenced May 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In response to attempting to add a RTL language as a locale option for Storybook, this PR removes
@chakra-ui/storybook-addonin favor of a local decorator setup.It is expected that the addon will not be updated due to ongoing building of Chakra v3 (which will deprecate the addon). In it's current state, the addon is not set up to properly sync with the changing of locale direction via
i18next, affecting DX.Creation of a local decorator similar to the addon expects a resolution to this, along with other modifications.
The
.storybook/typesbrings in thegetThemingArgTypesfrom the addon to generate SB controls based on the given component theme. (Currently in use inButton.stories)The Farsi language is added to SB as a locale option to generate RTL snapshots in Chromatic.