revert: remove Coin Wallet #12948
revert: remove Coin Wallet #12948
Conversation
mahnunchik
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks for bringing this up @mahnunchik Since this wallet was out of date, I think we should make sure the information we have is updated. Do you mind filling this out so we can have an up to date listing for Coin Wallet and review it in its current state. |
corwintines
added
Status: Blocked 🛑
|
@corwintines done #12970 |
|
@corwintines ping |
|
Thanks @mahnunchik! @corwintines Have assigned you for review to the issue and PR |
wackerow
added
the
needs product review 🕵️
wackerow
added
duplicate 🐥🐥
src/data/wallets/wallet-data.ts
Outdated
| @@ -408,6 +409,76 @@ export const walletsData: WalletData[] = [ | |||
| onboard_documentation: "https://docs.safe.global/", | |||
| documentation: "https://docs.safe.global/", | |||
| }, | |||
| { | |||
| last_updated: "May 10, 2024", | |||
| name: "Coin wallet", | |||
There was a problem hiding this comment.
Per usage on https://coin.space/
| name: "Coin wallet", | |
| name: "Coin Wallet", |
There was a problem hiding this comment.
Lgtm! Thanks @mahnunchik... I can't commit to your branch so I'm just going to bring this in and we can patch the capitalization of the name separately.
|
Actually, looks like there are some conflicts which I'm unable to clear myself. @mahnunchik Mind fixing those up and then we can merge in? |
mahnunchik
force-pushed
the
revert-remove-coinwallet
branch
from
cfdeb80 to
84393e8
Compare
|
@wackerow I've rebased on top of current dev branch. |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
@all-contributors please add @mahnunchik for tool |
|
I've put up a pull request to add @mahnunchik! 🎉 |
Add Coin Wallet back.
Description
It seems Coin Wallet was removed by mistake. Coin Wallet supports EIP-1559.
I've updated features list as well.
Related Issue