Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out TranslationBanner components until logic is fixed #13005

Merged
merged 1 commit into from
May 21, 2024
Merged

Comment out TranslationBanner components until logic is fixed #13005

merged 1 commit into from
May 21, 2024

Conversation

corwintines
Copy link
Member

Description

Commenting out TranslationBanner components until logic for rendering right banner is resolved

@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 242d5e2
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/664c0c491bbdc60008a0bfcf
😎 Deploy Preview https://deploy-preview-13005--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 48 (🔴 down 8 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 95 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

minimalsm
minimalsm approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)!

@minimalsm minimalsm merged commit 19254c0 into dev May 21, 2024
10 checks passed
@minimalsm minimalsm deleted the patchOutTranslationBanner branch May 21, 2024 10:32
This was referenced May 22, 2024
Merged
Merged
@corwintines corwintines mentioned this pull request Jun 11, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corwintines @minimalsm