-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: select styles optimization #13006
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lighthouse scores are calculated based on the latest audit results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview deploy looks good. Will let someone else double-check code, but it would be good to get this in this week's deploy.
@coderabbitai review |
Actions PerformedReview triggered.
|
WalkthroughThe changes across the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Files skipped from review due to trivial changes (2)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Currently, all the
Select
component related code is being bundled in the main_app.js
file which is not good since this code is only used by 4 different pages. We should only have global used code in this bundle.Description
This PR creates the select styles context provider in a different file to have a better bundle generation.
Before:

Now:

Summary by CodeRabbit
Refactor
Select
component for better maintainability.Select
component.Style
Select
components to ensure consistent and customizable styles.Chores