Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add explicit matcher for the root path to work on dev mode #13018

Merged
merged 1 commit into from
May 22, 2024

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented May 22, 2024

Description

Adds missing root route to the middleware matcher.

Copy link

netlify bot commented May 22, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit aa35e86
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/664e0ee572bdc90008685e1a
😎 Deploy Preview https://deploy-preview-13018--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 42 (🔴 down 14 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 93 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow
Copy link
Member

@pettinarip Any reason this is in draft still? This seems to be fixing the localhost issues we were having.

@pettinarip pettinarip marked this pull request as ready for review May 22, 2024 16:41
@pettinarip
Copy link
Member Author

@pettinarip Any reason this is in draft still? This seems to be fixing the localhost issues we were having.

Just wanted to avoid an early merge bc I didn't know if this was going to work on Netlify. It looks like it is also working fine on the Netlify servers.

@pettinarip pettinarip merged commit ab9e84f into dev May 22, 2024
6 checks passed
@pettinarip pettinarip deleted the middleware-root-path branch May 22, 2024 16:43
This was referenced Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants