Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client diversity developer doc - comma misplaced #13026

Merged
merged 1 commit into from
May 28, 2024
Merged

Update client diversity developer doc - comma misplaced #13026

merged 1 commit into from
May 28, 2024

Conversation

zkVlad
Copy link
Contributor

@zkVlad zkVlad commented May 23, 2024

Description

Related Issue

@netlify Netlify
Copy link

netlify bot commented May 23, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 6371e70
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/664f826b0c56d30008ef428d
😎 Deploy Preview https://deploy-preview-13026--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 32 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

minimalsm
minimalsm approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zkVlad, nice catch, thanks!

@minimalsm
Copy link
Contributor

@all-contributors please add @zkVlad for docs

@allcontributors allcontributors bot mentioned this pull request May 28, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@minimalsm

I've put up a pull request to add @zkVlad! 🎉

@minimalsm minimalsm changed the title Update index.md - comma misplaced Update client diversity developer doc - comma misplaced May 28, 2024
@minimalsm minimalsm merged commit a1f7c89 into ethereum:dev May 28, 2024
5 of 6 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented May 28, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Jun 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkVlad @minimalsm