Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: lazy load nav menu content #13065

Merged
merged 4 commits into from
May 30, 2024

Conversation

nhsz
Copy link
Member

@nhsz nhsz commented May 29, 2024

Description

  • extracts MenuContent component
  • MenuContent lazy loading
  • updates Nav/Menu component
  • updates @radix-ui imports to bring only neccesary components

Copy link

netlify bot commented May 29, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 6efc82c
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6657374e8e1b370008dac8fe
😎 Deploy Preview https://deploy-preview-13065--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🟢 up 9 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interface seems to be working well, nice job @nhsz! Looks like the Lighthouse performance metric is scoring about 9 points higher.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pettinarip pettinarip merged commit b82ca32 into dev May 30, 2024
10 checks passed
@pettinarip pettinarip deleted the performance-lazy-load-nav-menu-content branch May 30, 2024 15:51
This was referenced Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants