Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add url to dapp listing template #13133

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: add url to dapp listing template #13133

merged 1 commit into from
Jun 12, 2024

Conversation

wackerow
Copy link
Member

Description

  • Add required "url" input for suggest_dapp.yaml issue template

Related Issue

  • Discovered during issue reviews; dapp listing requests lacking this information

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Jun 10, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 10, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit ffd9ecb
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/666789ba0f036f00080bd3b0
😎 Deploy Preview https://deploy-preview-13133--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 44 (🟢 up 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nhsz
nhsz approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wackerow wackerow merged commit 6408d06 into dev Jun 12, 2024
6 checks passed
@wackerow wackerow deleted the dapp-listing branch June 12, 2024 21:40
This was referenced Jun 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhsz nhsz nhsz approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wackerow @nhsz