-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specified that part of the bounty gets burned and the remainder awarded to the validator #13136
Conversation
…ded to the verifier
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@coderabbitai review |
WalkthroughThe recent changes to the Ethereum documentation involve an update to the bounty handling mechanism in Ethereum transactions. Previously, the entire bounty was awarded to the participant who verified and executed the transaction. Now, a portion of the bounty is burned, and the remaining part is awarded to the participant. This update aims to refine the incentive structure within the Ethereum network. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant EthereumNetwork
participant Verifier
User->>EthereumNetwork: Submit Transaction
EthereumNetwork->>Verifier: Request Verification
Verifier->>EthereumNetwork: Verify and Execute Transaction
EthereumNetwork->>Verifier: Award Partial Bounty
EthereumNetwork->>EthereumNetwork: Burn Portion of Bounty
Verifier->>User: Confirmation of Transaction Execution
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional context usedLanguageTool
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
public/content/developers/docs/intro-to-ethereum/index.md (2)
Line range hint
43-43
: Consider rephrasing for directness.- it is used as a means to reward validators + it rewards validatorsThis change simplifies the language and makes the sentence more direct, improving readability.
Line range hint
53-53
: Remove the colon after "such as".- services such as: marketplaces, financial instruments, games, etc. + services such as marketplaces, financial instruments, games, etc.The colon is unnecessary here and removing it improves grammatical correctness.
@@ -36,7 +36,7 @@ Cryptographic mechanisms ensure that once transactions are verified as valid and | |||
|
|||
**Ether (ETH)** is the native cryptocurrency of Ethereum. The purpose of ETH is to allow for a market for computation. Such a market provides an economic incentive for participants to verify and execute transaction requests and provide computational resources to the network. | |||
|
|||
Any participant who broadcasts a transaction request must also offer some amount of ETH to the network as a bounty. The network will award this bounty to whoever eventually does the work of verifying the transaction, executing it, committing it to the blockchain, and broadcasting it to the network. | |||
Any participant who broadcasts a transaction request must also offer some amount of ETH to the network as a bounty. The network will burn part of the bounty and award the rest to whoever eventually does the work of verifying the transaction, executing it, committing it to the blockchain, and broadcasting it to the network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the proportion of the bounty that is burned and awarded.
The text states that part of the bounty is burned and the rest awarded, but it doesn't specify the proportions or the conditions under which these actions occur. It would enhance clarity and user understanding to specify these details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with this code rabbit comment, but I'm not sure it's worth getting into that on this page. There is an entire separate gas page that can get into the details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mcmoodoo! Looks good
@@ -36,7 +36,7 @@ Cryptographic mechanisms ensure that once transactions are verified as valid and | |||
|
|||
**Ether (ETH)** is the native cryptocurrency of Ethereum. The purpose of ETH is to allow for a market for computation. Such a market provides an economic incentive for participants to verify and execute transaction requests and provide computational resources to the network. | |||
|
|||
Any participant who broadcasts a transaction request must also offer some amount of ETH to the network as a bounty. The network will award this bounty to whoever eventually does the work of verifying the transaction, executing it, committing it to the blockchain, and broadcasting it to the network. | |||
Any participant who broadcasts a transaction request must also offer some amount of ETH to the network as a bounty. The network will burn part of the bounty and award the rest to whoever eventually does the work of verifying the transaction, executing it, committing it to the blockchain, and broadcasting it to the network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with this code rabbit comment, but I'm not sure it's worth getting into that on this page. There is an entire separate gas page that can get into the details.
…ded to the verifier
Description
Related Issue
Summary by CodeRabbit