-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: lazy load menus #13141
Performance: lazy load menus #13141
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lighthouse scores are calculated based on the latest audit results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @pettinarip! Just one bug at the screen breakpoint I left a suggestion for, then can pull in
I like the use of lazy
and Suspect
. Found this web.dev article a handy refresher on this for anyone curious.
Remind me, did we settle on not showing any type of loading fallback here?
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
This PR loads the mobile menu async using
lazy
andSuspense
for better UX and TTI metrics. The idea is to display these interactive elements only when they are ready to be used, which mostly affects the users with a slow connection.Details:
Suspense
to display both at the same time