-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update zksync name + add ecosystem portal + update docs links #13142
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @zk-Lumi, it's okay, but I'll explain... Part of why we try to avoid changing non-English files directly through GitHub is because these won't sync to Crowdin where all of our translations are managed. This is the rough flow: English content changes in GitHub repo -> English content pushed to Crowdin -> Translated / approved -> Approved non-English translations pulled into GitHub (1st of each month) If we alter non-English content in GitHub, Crowdin doesn't know about these. On the 1st of the month, automated PRs will attempt to revert these changes when the Crowdin translations are pulled. For this reason, typically we try to update the English file only, upload that to Crowdin where the string(s) can be corrected, approved, and then those will be imported back into the GitHub repo on their own schedule. @lukassim In the meantime, what is the quickest way we could apply a name/capitalization change like this to every language on the Crowdin side? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulling in, thanks @zk-Lumi
Thanks mate, really appreciate it ❤️ |
Description
Related Issue
@wackerow is it a problem that I updated docs URLs and spelling of ZKsync for non-english pages (outside of Crowdin)?
I know normally wouldn't be allowed but ->