Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update zksync name + add ecosystem portal + update docs links #13142

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

zk-Lumi
Copy link
Contributor

@zk-Lumi zk-Lumi commented Jun 11, 2024

Description

  • Updated "zkSync" -> "ZKsync" according to new branding
  • Added ZKsync Ecosystem Portal Page
  • Updated all broken links to docs site for DA

Related Issue

@wackerow is it a problem that I updated docs URLs and spelling of ZKsync for non-english pages (outside of Crowdin)?

I know normally wouldn't be allowed but ->

  • Links were all different to zkPorter DA across translations, and broken in many cases.
  • I didn't do any translation work (only updated zkSync -> ZKsync)

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jun 11, 2024
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit a2ffaf0
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66686a979465200008acd486
😎 Deploy Preview https://deploy-preview-13142--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 45 (🟢 up 7 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@zk-Lumi zk-Lumi marked this pull request as ready for review June 11, 2024 15:22
@wackerow
Copy link
Member

@wackerow is it a problem that I updated docs URLs and spelling of ZKsync for non-english pages (outside of Crowdin)?

Hey @zk-Lumi, it's okay, but I'll explain...

Part of why we try to avoid changing non-English files directly through GitHub is because these won't sync to Crowdin where all of our translations are managed. This is the rough flow:

English content changes in GitHub repo -> English content pushed to Crowdin -> Translated / approved -> Approved non-English translations pulled into GitHub (1st of each month)

If we alter non-English content in GitHub, Crowdin doesn't know about these. On the 1st of the month, automated PRs will attempt to revert these changes when the Crowdin translations are pulled.

For this reason, typically we try to update the English file only, upload that to Crowdin where the string(s) can be corrected, approved, and then those will be imported back into the GitHub repo on their own schedule.


@lukassim In the meantime, what is the quickest way we could apply a name/capitalization change like this to every language on the Crowdin side?

@wackerow wackerow added the Update Crowdin PR introduces changes that need to be updated in Crowdin label Jun 21, 2024
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulling in, thanks @zk-Lumi

@wackerow wackerow merged commit eecd485 into ethereum:dev Jun 21, 2024
6 of 7 checks passed
@wackerow wackerow added update 🔄 Related to updating out-of-date content or data and removed translation 🌍 This is related to our Translation Program content 🖋️ This involves copy additions or edits labels Jun 21, 2024
@zk-Lumi
Copy link
Contributor Author

zk-Lumi commented Jun 21, 2024

Thanks mate, really appreciate it ❤️

This was referenced Jul 10, 2024
@lukassim lukassim removed the Update Crowdin PR introduces changes that need to be updated in Crowdin label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update 🔄 Related to updating out-of-date content or data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants