-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
performance: get last edit/deploy locale timestamp for layouts on build time #13153
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice job @nhsz! Just a stray comment I assume we don't want anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! nice job @nhsz
This PR updates how
getLocaleTimestamp
is used across layouts and pages, to calculate the newlastEditLocaleTimestamp
&lastDeployLocaleTimestamp
values on build time instead of executing this logic on runtime, and updates the corresponding components, interfaces and types to use them properly.Description
src/pages/[...slug].tsx
src/pages/_app.tsx
src/pages/assets.tsx
src/pages/bug-bounty.tsx
src/pages/community.tsx
src/pages/contributing/translation-program/acknowledgements.tsx
src/pages/contributing/translation-program/contributors.tsx
src/pages/dapps.tsx
src/pages/developers/index.tsx
src/pages/developers/learning-tools.tsx
src/pages/developers/local-environment.tsx
src/pages/developers/tutorials.tsx
src/pages/eth.tsx
src/pages/gas.tsx
src/pages/get-eth.tsx
src/pages/index.tsx
src/pages/index.tsx
src/pages/layer-2.tsx
src/pages/learn.tsx
src/pages/learn.tsx
src/pages/quizzes.tsx
src/pages/roadmap/vision.tsx
src/pages/roadmap/vision.tsx
src/pages/run-a-node.tsx
src/pages/stablecoins.tsx
src/pages/staking/deposit-contract.tsx
src/pages/staking/index.tsx
src/pages/wallets/find-wallet.tsx
src/pages/wallets/index.tsx
src/pages/what-is-ethereum.tsx
src/components/FileContributors.tsx
(useslastEditLocaleTimestamp
)src/components/Footer.tsx
(useslastDeployLocaleTimestamp
)src/layouts/Docs.tsx
src/layouts/Roadmap.tsx
src/layouts/RootLayout.tsx
src/layouts/Static.tsx
src/layouts/Tutorial.tsx
src/layouts/Upgrade.tsx
MdPageContent
Root
BasePageProps
lastUpdatedDate
&lastDeployDate
page props