-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: french typos #13173
fix: french typos #13173
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
maybe @isabelladebrito can help here |
Hey @omahs! Appreciate you posting these suggestions. Our challenge with updates such as these is we are limited in our ability to properly review these from GitHub. We handle all of our translations through our Crowdin project; Have you been over there by chance? (Here is more information on our Translation Program) cc: @lukassim Is there anyone who could review these changes here? Or should we move these over to Crowdin first? |
Hi @wackerow, yup I'm already on Crowdin and participated in the last Translatathon. I even received a Community Champion badge :) |
Oh that's awesome! Thank you for all your help so far and continued support...
Appreciate the feedback about the process here. @lukassim How would you recommend going forward here? @omahs Have you made these changes in Crowdin by chance? Would you be willing to if not? @lukassim If we're comfortable with it we can pull these in on GitHub. In either case, we should also make sure Crowdin is updated to get these strings formally approved, so they won't get overwritten when the next round of imports occurs. |
Just tried to, but I can't always find the right file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay great, thanks @omahs! I tried to update any that remained in Crowdin so we should be good here.
FWIW, to find these I've been using https://crowdin.com/editor/ethereum-org > French > Open file and search for the last directory of the index.md file, so public/content/translations/fr/refi/index.md
=> Search refi
and it should revel the folder with the needed file inside > Double click > Search in file > Paste string snippet to find it.
You likely know this though, so if you're hitting other issues feel free to let @lukassim or I know and we can try to help resolve.
@all-contributors please add @omahs for translation |
I've put up a pull request to add @omahs! 🎉 |
fix: french typos