Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: french typos #13173

Merged
merged 8 commits into from
Jun 27, 2024
Merged

fix: french typos #13173

merged 8 commits into from
Jun 27, 2024

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Jun 14, 2024

fix: french typos

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jun 14, 2024
Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit eb39f58
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/666c5863567c7b0008ee7262
😎 Deploy Preview https://deploy-preview-13173--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 43 (🟢 up 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 84 (🔴 down 8 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nhsz
Copy link
Member

nhsz commented Jun 14, 2024

maybe @isabelladebrito can help here

@wackerow wackerow added Update Crowdin PR introduces changes that need to be updated in Crowdin question ❓ Further information is requested Status: Blocked 🛑 This is blocked labels Jun 21, 2024
@wackerow
Copy link
Member

Hey @omahs! Appreciate you posting these suggestions. Our challenge with updates such as these is we are limited in our ability to properly review these from GitHub.

We handle all of our translations through our Crowdin project; Have you been over there by chance? (Here is more information on our Translation Program)

cc: @lukassim Is there anyone who could review these changes here? Or should we move these over to Crowdin first?

@omahs
Copy link
Contributor Author

omahs commented Jun 22, 2024

Hi @wackerow, yup I'm already on Crowdin and participated in the last Translatathon. I even received a Community Champion badge :)
I prefer Github for edits, with Crowdin I feel like this wouldn't be seen. I've seen some questions take months to get answers there.

@wackerow
Copy link
Member

Oh that's awesome! Thank you for all your help so far and continued support...

I prefer Github for edits, with Crowdin I feel like this wouldn't be seen. I've seen some questions take months to get answers there.

Appreciate the feedback about the process here. @lukassim How would you recommend going forward here?

@omahs Have you made these changes in Crowdin by chance? Would you be willing to if not?

@lukassim If we're comfortable with it we can pull these in on GitHub. In either case, we should also make sure Crowdin is updated to get these strings formally approved, so they won't get overwritten when the next round of imports occurs.

@omahs
Copy link
Contributor Author

omahs commented Jun 26, 2024

Have you made these changes in Crowdin by chance? Would you be willing to if not?

Just tried to, but I can't always find the right file

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay great, thanks @omahs! I tried to update any that remained in Crowdin so we should be good here.

FWIW, to find these I've been using https://crowdin.com/editor/ethereum-org > French > Open file and search for the last directory of the index.md file, so public/content/translations/fr/refi/index.md => Search refi and it should revel the folder with the needed file inside > Double click > Search in file > Paste string snippet to find it.

You likely know this though, so if you're hitting other issues feel free to let @lukassim or I know and we can try to help resolve.

@wackerow wackerow merged commit 8855806 into ethereum:dev Jun 27, 2024
6 of 7 checks passed
@wackerow
Copy link
Member

@all-contributors please add @omahs for translation

Copy link
Contributor

@wackerow

I've put up a pull request to add @omahs! 🎉

@lukassim lukassim removed the Update Crowdin PR introduces changes that need to be updated in Crowdin label Jul 2, 2024
This was referenced Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits question ❓ Further information is requested Status: Blocked 🛑 This is blocked translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants