Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove language redirects #13193

Merged
merged 3 commits into from
Aug 12, 2024
Merged

remove language redirects #13193

merged 3 commits into from
Aug 12, 2024

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Jun 18, 2024

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 26f61f7
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66ba68649ea8120008cdf24d
😎 Deploy Preview https://deploy-preview-13193--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 46 (🔴 down 2 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 83 (🔴 down 14 from production)
SEO: 93 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow
Copy link
Member

Fixes the smart-contract/languages issue, but now the /languages/ or <lang>/languages/ redirects no longer work.

@wackerow wackerow marked this pull request as draft June 18, 2024 23:49
@corwintines corwintines marked this pull request as ready for review July 4, 2024 03:14
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://deploy-preview-13193--ethereumorg.netlify.app/en/developers/docs/smart-contracts/languages/

image

Not sure this is working as we'd like; the above page is not loading for me.

@wackerow wackerow marked this pull request as draft July 18, 2024 14:10
@corwintines corwintines changed the title [TEST] remove language redirects remove language redirects Aug 12, 2024
@corwintines corwintines marked this pull request as ready for review August 12, 2024 16:42
This reverts commit ffc463b.
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating the root /languages redirect

@wackerow wackerow merged commit c8f1555 into dev Aug 12, 2024
6 checks passed
@wackerow wackerow deleted the languageRedirects branch August 12, 2024 22:25
This was referenced Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: dev docs /smart-contracts/languages/ not loading
2 participants