Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node syncing content [Fixes #12003] #13201

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Update node syncing content [Fixes #12003] #13201

merged 8 commits into from
Jun 27, 2024

Conversation

m4sterbunny
Copy link
Contributor

@m4sterbunny m4sterbunny commented Jun 19, 2024 •
edited
Loading

Description

Execution client summary table did not link users to sync types
Sync types were poorly identified and incomplete

Small proofs including:

  • proof-of-stake > Proof of Stake (PoS) acronym then applied
  • mainnet > Mainnet for Ethereum

Issue

Fixes #12003

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Jun 19, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 19, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8398b1a
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/667d25a4797a1e000892b995
😎 Deploy Preview https://deploy-preview-13201--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 42 (🔴 down 7 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@m4sterbunny m4sterbunny mentioned this pull request Jun 19, 2024
Closed
@m4sterbunny
Copy link
Contributor Author

m4sterbunny commented Jun 19, 2024 •
edited
Loading

I think I need to update Snap further for better detail:
there are 2 things to sync
Blockchain
World state
Snap sync: Blockchain from genesis, World state from trusted checkpoint

wackerow
wackerow requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m4sterbunny! Left a few comments/requests to clean things up then think we can get this in soon

public/content/developers/docs/nodes-and-clients/index.md Outdated Show resolved Hide resolved
public/content/developers/docs/nodes-and-clients/index.md Outdated Show resolved Hide resolved
public/content/developers/docs/nodes-and-clients/index.md Outdated Show resolved Hide resolved
public/content/developers/docs/nodes-and-clients/index.md Outdated Show resolved Hide resolved
public/content/developers/docs/nodes-and-clients/index.md Outdated Show resolved Hide resolved
@wackerow
Copy link
Member

Quick housekeeping notes...

"12003(docs):fixes as per issue"

Issue Names: I see you're referencing an issue (12003). By convention, we'll place [Fixes #12003] at the end of the issue name. Please try to start with a brief summary title for your changes. Ie. "Update node syncing content [Fixes #12003]` ("fixes as per issue" isn't very helpful when skimming through issue names 😆 )

More on auto-closing stuff

image

Issue Body: Try to use the default template to get started. Under a ## Description you can describe in more detail your changes, then under ## Relate issue you can add - Fixes #12003 to cleanly link the PR to the issue it's fixing.

Thanks!

@wackerow wackerow changed the title 12003(docs):fixes as per issue Update node syncing content [Fixes #12003] Jun 26, 2024
m4sterbunny and others added 5 commits June 26, 2024 09:27
@m4sterbunny @wackerow
Update public/content/developers/docs/nodes-and-clients/index.md
e868479 
as per review

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@m4sterbunny @wackerow
Update public/content/developers/docs/nodes-and-clients/index.md
0ff779f 
as per review

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@m4sterbunny @wackerow
Update public/content/developers/docs/nodes-and-clients/index.md
0f06983 
as per review

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@m4sterbunny @wackerow
Update public/content/developers/docs/nodes-and-clients/index.md
417cdde 
as per review

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@m4sterbunny
Update index.md
11310a6 
updates heading level as per review
BUT need to verify did I introduce the heading that impacted
@m4sterbunny m4sterbunny mentioned this pull request Jun 26, 2024
Closed
@m4sterbunny
Copy link
Contributor Author

I think I resolved all @wackerow PTAL
Apologies for poor hygiene, been lone writer for too long >> will learn to play nicely with others again

@m4sterbunny @wackerow
Update public/content/developers/docs/nodes-and-clients/index.md
8398b1a 
as per review

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
wackerow
wackerow approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot @m4sterbunny! Bringing in

@wackerow wackerow merged commit 3144211 into ethereum:dev Jun 27, 2024
6 checks passed
@wackerow
Copy link
Member

@all-contributors please add @m4sterbunny for content

@allcontributors allcontributors bot mentioned this pull request Jun 27, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@wackerow

I've put up a pull request to add @m4sterbunny! 🎉

@corwintines corwintines mentioned this pull request Jul 10, 2024
Merged
@corwintines corwintines mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various sync strategies are listed but not explained
2 participants
@m4sterbunny @wackerow