-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix heading styles in Glossary Definition and Tooltip #13205
Conversation
… the glossary tooltip open state
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pettinarip quick thought from me 😁
export const Basic: Story = {} | ||
|
||
// for chromatic story snapshot showing the rendered popover | ||
export const OnOpen: Story = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a decorator here, where it provides enough white-space to cover the visible tooltip. Otherwise the tooltip will be cropped out in the chromatic snapshot.
The decorator can be supplied at the individual story level. (There is currently a decorator at the component level for the Tooltip for this very reason)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! great point. Thanks for sharing, I was thinking about how to deal with this issue and couldn't remember what you did.
@pettinarip @TylerAPfledderer I think this will be ready now I added the |
@nloureiro Mind approving these changes in Chromatic if they look okay to you? |
Nice! thanks! |
looks good to me. approved on Chromatic :) |
In recent changes, we have changed a bit how we display the heading on the Glossary Definition component, and this affects the Glossary Tooltip styles.
Description
This PR fixes the style issues by:
Bonus: added a new story for the open state of GlossaryTooltip to avoid getting these regressions again.