fix: wallet filter device boolean tracking #13207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes reversal of true/false for "Toggle Desktop/Browser/Mobile". Adds "to" to differentiate between old logs (where T/F have flipped meanings) and the new corrected entries.
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
commented
Jun 19, 2024
| @@ -176,7 +176,7 @@ const WalletFilterFeature = ({ | |||
| eventAction: `${filterOption.title}`, | |||
| eventName: `Toggle ${ | |||
| item.title | |||
| } ${!item.showOptions}`, | |||
| } to ${item.showOptions}`, | |||
There was a problem hiding this comment.
Tested all the different options we have... this event is only fired for the Browser Desktop or Mobile switches shown here
corwintines
approved these changes
Jun 24, 2024
|
lgtm |
nhsz
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example of new usage: If "Mobile" is switched from off to on, it will log
Toggle Mobile to true.Related Issue
None filed; from UX research sync