Upgrade TS to v5.5 #13224
Merged
Upgrade TS to v5.5 #13224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
wackerow,
corwintines,
minimalsm and
nhsz
as code owners
github-actions
bot
added
the
dependencies 📦
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
commented
Jun 21, 2024
| @@ -236,8 +236,8 @@ const Codeblock = ({ | |||
| className = codeLanguage || "" | |||
| } | |||
|
|
|||
| const matches = className?.match(/language-(?<lang>.*)/) | |||
There was a problem hiding this comment.
Now ts can check regexs! got an error here: Named capturing groups are only available when targeting 'ES2018' or later
wackerow
approved these changes
Jun 21, 2024
| @@ -236,8 +236,8 @@ const Codeblock = ({ | |||
| className = codeLanguage || "" | |||
| } | |||
|
|
|||
| const matches = className?.match(/language-(?<lang>.*)/) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades TS.