Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add meeds to dapps #13241

Merged
merged 4 commits into from
Jun 26, 2024
Merged

add meeds to dapps #13241

merged 4 commits into from
Jun 26, 2024

Conversation

plamarque
Copy link
Contributor

@plamarque plamarque commented Jun 25, 2024 •
edited by wackerow
Loading

Description

Add meeds logo and description in dapps page in category finance/payments

Related Issue

@plamarque
add meeds to dapps
e0e09ea 
 ethereum#13021 : Add meeds logo and description in finance/payments
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jun 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 99f02b3
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/667c951b5ef83c0008d1066e
😎 Deploy Preview https://deploy-preview-13241--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 44 (🔴 down 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 84 (🔴 down 8 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@plamarque plamarque mentioned this pull request Jun 25, 2024
Closed
2 tasks
wackerow
wackerow requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @plamarque, as noted in #13021 (comment) go ahead and move this to a new "Community" section within "Social"... let me know if you have issues with this change, happy to help

plamarque and others added 2 commits June 26, 2024 23:31
@plamarque
moved Meeds to Social > Community
ff94918 
- created new Community category in Social
- moved Meeds from Payment to Community
- updated description to reflect community building tool
@wackerow
fix: move category to new row
99f02b3
wackerow
wackerow approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @plamarque! Looks good. I added a commit to just move this into it's own row per convention on that page. Bringing in

@wackerow wackerow merged commit 14dcb15 into ethereum:dev Jun 26, 2024
8 of 10 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Jun 26, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @plamarque for tool

@allcontributors allcontributors bot mentioned this pull request Jun 26, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@wackerow

I've put up a pull request to add @plamarque! 🎉

@plamarque
Copy link
Contributor Author

Awesome, thanks @wackerow !

This was referenced Jul 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@nhsz nhsz Awaiting requested review from nhsz

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest a dapp : Meeds
2 participants
@plamarque @wackerow