Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Nav): shift hover transition to button children icon and add focus state #13261

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

tomasgrusz
Copy link
Contributor

Old PR

  • remove hover animation from IconButton
  • add hover animation to IconButton's child svg (the icon)
  • add same animation to :focus state

Related Issue

Bug: Click zone on color toggle rotating with icon effect

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 30c9240
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/667d2b01dac08f0008ef46ca
😎 Deploy Preview https://deploy-preview-13261--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 43 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomasgrusz tomasgrusz changed the title style: shift hover transition to button children icon and add focus state style(Nav): shift hover transition to button children icon and add focus state Jun 27, 2024
@corwintines corwintines self-assigned this Jul 3, 2024
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is great. Thanks @tomasgrusz!

@corwintines corwintines merged commit f7eb695 into ethereum:dev Jul 3, 2024
9 of 10 checks passed
This was referenced Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants