Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: update op rollup fees section to match 4844 specs #13309

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

iankressin
Copy link
Contributor

@iankressin iankressin commented Jul 3, 2024

Description

Update section "How do optimistic rollup fees work?" to match EIP-4844 specs

Related issues

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Jul 3, 2024
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 3349bfa
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6697c9f2ed7adc0008e39b84
😎 Deploy Preview https://deploy-preview-13309--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🔴 down 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @iankressin! Just left a small suggestion to adjust how we introduce/use the term "blob", along with tiny punctuation/capitalization fixes. Then we should be able to get this in!

@iankressin
Copy link
Contributor Author

Looks good @iankressin! Just left a small suggestion to adjust how we introduce/use the term "blob", along with tiny punctuation/capitalization fixes. Then we should be able to get this in!

Thanks for the review! I'll update it soon

Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
@iankressin
Copy link
Contributor Author

@wackerow PR updated

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @iankressin

@wackerow wackerow merged commit 1a8bc92 into ethereum:dev Jul 17, 2024
5 of 6 checks passed
Copy link

gitpoap-bot bot commented Jul 17, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @iankressin for maintenance

Copy link
Contributor

@wackerow

I've put up a pull request to add @iankressin! 🎉

This was referenced Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "How do optimistic rollup fees work?" on Optimistic rollups
2 participants