Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set Checkbox component for ShadCN #13441

Merged

Conversation

TylerAPfledderer
Copy link
Contributor

@TylerAPfledderer TylerAPfledderer commented Jul 21, 2024

Description

Set up the Checkbox component for ShadCN/Tailwind

@github-actions github-actions bot added the dependencies 📦 Changes related to project dependencies label Jul 21, 2024
Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for ethereumorg canceled.

Name Link
🔨 Latest commit ee7fed0
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66a8f5b71dcc9e0008421a06

plugins: [require("tailwindcss-animate")],
plugins: [
require("tailwindcss-animate"),
plugin(function ({ matchVariant }) {
Copy link
Contributor Author

@TylerAPfledderer TylerAPfledderer Jul 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin creates a custom modifier for the :not() pseudo. It allows for either...

An arbitrary variant

/* "not-[:checked]:bg-primary" */

.not-\[\:checked\]\:bg-primary:not(:checked) {
    background-color: var(--primary);
}

Or a specifically defined variant, such as disabled here

/* not-disabled:bg-primary */

.not-disabled\:bg-primary:not(:disabled) {
    background-color: var(--primary);
}

@TylerAPfledderer TylerAPfledderer marked this pull request as ready for review July 23, 2024 03:39
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pettinarip pettinarip merged commit dd49640 into ethereum:dev Jul 30, 2024
6 of 10 checks passed
@TylerAPfledderer TylerAPfledderer deleted the feat/shadcn-migrate-checkbox branch August 1, 2024 15:03
This was referenced Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📦 Changes related to project dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants