Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further deprecate to for href #13485

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Further deprecate to for href #13485

merged 3 commits into from
Jul 24, 2024

Conversation

corwintines
Copy link
Member

Description

  • Goes through and further deprecates to props

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits event 📅 This issue or pull request is related to an event listing tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Jul 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 91c1b66
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66a16b1aa65cb1000887ec46
😎 Deploy Preview https://deploy-preview-13485--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 42 (🔴 down 9 from production)
Accessibility: 93 (🟢 up 1 from production)
Best Practices: 91 (🔴 down 7 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

corwintines
corwintines commented Jul 24, 2024
View reviewed changes
src/components/Link.tsx Outdated Show resolved Hide resolved
@wackerow wackerow added the Update Crowdin PR introduces changes that need to be updated in Crowdin label Jul 24, 2024
wackerow
wackerow approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @lukassim Ideally these do not all get undone in the next Crowdin import... majority if not all should be content that should not be getting translated anyway, so hopefully there is a way to auto approve these.

@wackerow wackerow merged commit 4990bf4 into staging Jul 24, 2024
8 of 11 checks passed
@wackerow wackerow deleted the toDeprecation branch July 24, 2024 23:00
This was referenced Aug 7, 2024
Merged
Merged
@lukassim lukassim removed the Update Crowdin PR introduces changes that need to be updated in Crowdin label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits event 📅 This issue or pull request is related to an event listing tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corwintines @wackerow @lukassim