-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadcn migration - AdoptionChart #13662
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, lgtm! thanks @saurabhburade
@pettinarip The classNames are getting longer, Do you have any suggestions to maintain readability? |
I think one thing that @wackerow was doing is to break the line inside the className={cn(
"border border-solid px-2 py-[0.8rem] md:px-[1.2rem]",
"text-center text-[0.9rem] font-bold leading-none",
"last:rounded-t-2xl [&:nth-child(-n+2)]:rounded-bl-2xl [&:nth-child(-n+2)]:rounded-br-2xl",
className
)} One possible way to make it more readable. |
This is great!!! |
Description
Migrate AdoptionChart to tailwind.