Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadcn migration - AdoptionChart #13662

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

saurabhburade
Copy link
Contributor

Description

Migrate AdoptionChart to tailwind.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2e4553f
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66bf7dbd94c9220008aa4bc7
😎 Deploy Preview https://deploy-preview-13662--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 40 (🔴 down 9 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm! thanks @saurabhburade

@saurabhburade
Copy link
Contributor Author

@pettinarip The classNames are getting longer, Do you have any suggestions to maintain readability?

@pettinarip
Copy link
Member

@pettinarip The classNames are getting longer, Do you have any suggestions to maintain readability?

I think one thing that @wackerow was doing is to break the line inside the cn function and grouping related styles like this:

className={cn(
  "border border-solid px-2 py-[0.8rem] md:px-[1.2rem]",
  "text-center text-[0.9rem] font-bold leading-none",
  "last:rounded-t-2xl [&:nth-child(-n+2)]:rounded-bl-2xl [&:nth-child(-n+2)]:rounded-br-2xl",
  className
)}

One possible way to make it more readable.

@saurabhburade
Copy link
Contributor Author

saurabhburade commented Aug 16, 2024

One possible way to make it more readable.

This is great!!!

@pettinarip pettinarip merged commit 89854bc into ethereum:dev Aug 19, 2024
9 of 10 checks passed
This was referenced Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants